Repository navigation
Don't pass synthesized node to typeToTypeNode - #19578
Merged
Merged
Conversation
All of the other calls in extractSymbol are already correct.
Andrew Casey (amcasey)
requested a review
from Nathan Shively-Sanders (sandersn)
October 30, 2017 18:26
Nathan Shively-Sanders (sandersn)
approved these changes
Oct 30, 2017
Member
Author
|
Note that the asserts are in a separate commit in case they turn out to be too aggressive. |
This was referenced Oct 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19395