Skip to content

Check for --strict along with --noImplicitAny for code fix - #19390

Merged
Mohamed Hegazy (mhegazy) merged 1 commit into
masterfrom
fix19378
Oct 20, 2017
Merged

Mohamed Hegazy (mhegazy) merged 1 commit into
masterfrom
fix19378

Conversation

@mhegazy

Copy link
Copy Markdown
Contributor

Fixes #19378

@mhegazy

Copy link
Copy Markdown
Contributor Author

error related to gulp-typescript version.

@mhegazy
Mohamed Hegazy (mhegazy) merged commit fcb9d93 into master Oct 20, 2017
@mhegazy
Mohamed Hegazy (mhegazy) deleted the fix19378 branch October 20, 2017 23:48
function getAvailableActions(context: RefactorContext): ApplicableRefactorInfo[] | undefined {
if (context.program.getCompilerOptions().noImplicitAny) {
const options = context.program.getCompilerOptions();
if (options.noImplicitAny || options.strict) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about strict: true with noImplicitAny: false?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix up in #19427

@mhegazy

Copy link
Copy Markdown
Contributor Author

You are right. Will fix it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants