Repository navigation
Do not consider UMD alias symbols as visible within external modules - #18049
Merged
Wesley Wigham (weswigham) merged 2 commits intoSep 7, 2017
Merged
Wesley Wigham (weswigham) merged 2 commits into
Wesley Wigham (weswigham) merged 2 commits into
Conversation
Wesley Wigham (weswigham)
requested review from
a user,
Mohamed Hegazy (mhegazy),
Ron Buckton (rbuckton) and
Nathan Shively-Sanders (sandersn)
and removed request for
Nathan Shively-Sanders (sandersn)
August 25, 2017 20:49
ghost
mentioned this pull request
| @@ -0,0 +1,63 @@ | |||
| // @declaration: true | |||
There was a problem hiding this comment.
Use a minimal test that reproduces the error -- looking at this test I would have no idea what it's trying to test..
Contributor
There was a problem hiding this comment.
We should always strive for the smallest reproducible steps for a failure.
Member
Author
There was a problem hiding this comment.
It is now minimal
…in the symbol writer
Wesley Wigham (weswigham)
force-pushed
the
no-umd-globals-in-module-declarations
branch
from
September 5, 2017 20:36
b10dfac to
e0ae4b4
Compare
Mohamed Hegazy (mhegazy)
approved these changes
Sep 6, 2017
Wesley Wigham (weswigham)
deleted the
no-umd-globals-in-module-declarations
branch
December 20, 2017 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16155. In the example from the issue, this causes the type to be written without the alias. You can force the type to be written with an alias by making the module symbol or the type symbol visible within the file, as is typical for our current declaration emit.