Repository navigation
Make compiler options which map to a flag case-insensitive again - #17755
Merged
Wesley Wigham (weswigham) merged 1 commit intoAug 12, 2017
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
Ron Buckton (rbuckton) and
Sheetal Nandi (sheetalkamat)
August 12, 2017 00:41
Ron Buckton (rbuckton)
approved these changes
Aug 12, 2017
Ron Buckton (rbuckton)
left a comment
Ron Buckton (rbuckton)
left a comment
Contributor
There was a problem hiding this comment.
Daniel Rosenwasser (@DanielRosenwasser), can you take a look as well? I think we broke this when we switched to using our parsed to parse JSON over using JSON.parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some breaks in our RWC suite. We were not case sensitive before, so it was breaking to be so (and, more importantly, we didn't issue an error on case mismatch - we just silently did the wrong thing). This reintroduces case-insensitivity in our normalization of option-based options.