Repository navigation
Allow export default abstract class. Related to issue 3792. - #14657
Conversation
|
@erikmcc, It will cover your contributions to all Microsoft-managed open source projects. |
|
Erik McClenney (@erikmcc), thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Microsoft Contribution License Agreements (msftclas)
added
cla-signed
and removed
cla-required
labels
|
|
||
|
|
||
| ==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractManyKeywords.ts (3 errors) ==== | ||
| ==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractManyKeywords.ts (2 errors) ==== |
There was a problem hiding this comment.
Wow nice test name Arthur Ozga (@aozgaa)
|
👍 LGTM |
|
Awesome! It is a shame this doesn't support interfaces. I tend to abide by the rule that says if you have only one export, it should be the default, and I apply this even to interfaces. Regardless, I'm really glad to see this. Thank you! |
|
I'm planning on fixing that next. I just wanted to see what the PR
submission process was like before investing too much time.
…On Mar 31, 2017 3:26 PM, "Aluan Haddad" ***@***.***> wrote:
Awesome!
It is a shame this doesn't support interfaces. I tend to abide by the rule
that says if you have only one export, it should be the default, and I
apply this even to interfaces.
Regardless, I'm really glad to see this. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14657 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANbipOT8DVQ6v40yfrRGD0XRkWaA52A_ks5rrX2CgaJpZM4MdGCI>
.
|
|
Erik McClenney (@erikmcc) Does it make sense that I'm still getting an error if I use the |
|
We are not planning on changing the |
7 participants
Fixes (part of) #3792