Do not rename imports from ambient modules #8227

Activity

2. Mohamed Hegazy (mhegazy)

   added

   SuggestionAn idea for TypeScriptAn idea for TypeScript

   In DiscussionNot yet reached consensusNot yet reached consensus

   on May 20, 2016
3. Ryan Cavanaugh (RyanCavanaugh)

   added

   Help WantedYou can do thisYou can do this

   Effort: ModerateRequires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".

   and removed

   In DiscussionNot yet reached consensusNot yet reached consensus

   on Jun 9, 2016
4. RyanCavanaugh commented on Jun 9, 2016

   

   Ryan Cavanaugh (RyanCavanaugh)

   on Jun 9, 2016

   Member

   More actions

   Approved. The fix here is just to block rename invocations in certain syntactic locations (we can start with this particular one and add more as we find them).
5. Mohamed Hegazy (mhegazy)

   added this to the TypeScript 2.1 milestone on Jun 9, 2016
6. Mohamed Hegazy (mhegazy)

   assigned

   ghost

   on Jun 9, 2016
7. mhegazy commented on Jun 13, 2016

   

   Mohamed Hegazy (mhegazy)

   on Jun 13, 2016

   ContributorAuthor

   More actions

   This also should cover all symbols declared in .d.ts files, as long as the operation is not initiated from this .d.ts file.
8. Mohamed Hegazy (mhegazy)

   modified the milestones: TypeScript 2.1, FutureThis milestone has been deleted on Sep 29, 2016
9. bryanforbes commented on Jan 6, 2017

   

   Bryan Forbes (bryanforbes)

   on Jan 6, 2017

   Contributor

   More actions

   I believe the behavior I'm encountering is relevant to this bug. In a freshly initialized project, renaming things like Object and Number is prevented. Here is the tsconfig.json:

   {
       "compilerOptions": {
           "module": "commonjs",
           "target": "es5",
           "noImplicitAny": false,
           "sourceMap": false
       }
   }
   

   The file I'm attempting the rename in:

   Object.defineProperties({}, {})
   

   The request for the rename of Object:

   {"seq":8914211752108017,"type":"request","command":"rename","arguments":{"file":"src/foo.ts","line":1,"offset":1}}
   

   And the response:

   {"seq":0,"type":"response","command":"rename","request_seq":8914211752108017,"success":true,"body":{"info":{"canRename":false,"localizedErrorMessage":"You cannot rename elements that are defined in the standard TypeScript library."},"locs":[]}}
   

   This is expected. However, as soon as you add a lib entry to the tsconfig.json, renaming Object is permitted. Here is the tsconfig.json:

   {
       "compilerOptions": {
           "module": "commonjs",
           "lib": [
               "es2015"
           ],
           "target": "es5",
           "noImplicitAny": false,
           "sourceMap": false
       }
   }
   

   Using the same file as before, here is the request for the rename:

   {"seq":4041495444461493,"type":"request","command":"rename","arguments":{"file":"src/foo.ts","line":1,"offset":1}}
   

   And the response:

   {"seq":0,"type":"response","command":"rename","request_seq":4041495444461493,"success":true,"body":{"info":{"canRename":true,"kind":"interface","displayName":"Object","fullDisplayName":"Object","kindModifiers":"declare","triggerSpan":{"start":0,"length":6}},"locs":[{"file":"/Users/bryan/Projects/test-rename/node_modules/typescript/lib/lib.es5.d.ts","locs":[{"start":{"line":251,"offset":15},"end":{"line":251,"offset":21}}]},{"file":"src/foo.ts","locs":[{"start":{"line":1,"offset":1},"end":{"line":1,"offset":7}}]}]}}
   

   This also occurs in things included via TypeScript's @types system. At the very least, I would expect that rename requests would be denied ("canRename": false) if changes would occur in files included via "lib", "@types/*", "typeRoots", or "types".
10. zpdDG4gta8XKpMCd commented on Jan 6, 2017

    

    ZpdDG4gta (zpdDG4gta8XKpMCd)

    on Jan 6, 2017

    More actions

    related #11863
11. Ryan Cavanaugh (RyanCavanaugh)

    unassigned on Jul 17, 2019
12. brandonkal commented on Aug 23, 2019

    

    Brandon Kalinowski (brandonkal)

    on Aug 23, 2019

    More actions

    Perhaps this could be expanded to not rename things from node_modules (or at least give a warning) folder?
    VSCode decided to rename everything that was of type string and I had to reinstall node_modules. It really shouldn't be reaching into the dependencies folder.