Give template strings a different classification type #6513
Copy link
Copy link
Closed
Labels
Domain: APIRelates to the public API for TypeScriptRelates to the public API for TypeScriptSuggestionAn idea for TypeScriptAn idea for TypeScriptVisual StudioIntegration with Visual StudioIntegration with Visual StudioWon't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix itThe severity and priority of this issue do not warrant the time or complexity needed to fix it
Description
At the time, we just used "stringLiteral" because it was such a PITA to sync between the managed side and whatnot. We never followed up on it. Prompted by #6508.
Open questions:
- Do we want to classify
${and}specially? - If we do want to classify
${and}specially in templates, do we want to classify backticks? - What colors do we want to use in VS?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Domain: APIRelates to the public API for TypeScriptRelates to the public API for TypeScriptSuggestionAn idea for TypeScriptAn idea for TypeScriptVisual StudioIntegration with Visual StudioIntegration with Visual StudioWon't FixThe severity and priority of this issue do not warrant the time or complexity needed to fix itThe severity and priority of this issue do not warrant the time or complexity needed to fix it
Activity
derekcicerone-zz commentedon Jan 16, 2016
Thanks for checking. I don't have a strong opinion on the highlighting for string templates. It never hurts to have more specific classifications though - worst case we can keep coloring as strings. The syntax coloring I'd still really like is to distinguish between a normal comment and JSDoc.
basarat commentedon Jan 17, 2016
I am very happy with what is there currently in the syntactic analyzer (the one between lexical and semantic) 🌹 that I am using as a work in progress in alm.tools