Skip to content

Allow binding patterns in rest binding elements #6275

New issue
New issue
Closed
Closed
Allow binding patterns in rest binding elements#6275
Labels
BugA bug in TypeScriptES6Relates to the ES6 Spec
Milestone
Backlog

Description

@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)
opened on Dec 28, 2015

See #2519 (comment).

New grammar rules:

    BindingRestElement[Yield]:
        ...BindingIdentifier[?Yield]
        ...BindingPattern[?Yield]

Relevant section:

https://tc39.github.io/ecma262/#sec-destructuring-binding-patterns

Old work for disalllowing the construct was performed here: #2754.

Activity

  1. Daniel Rosenwasser (DanielRosenwasser)
    added
    BugA bug in TypeScript
    ES7Relates to the ES7 Spec
    on Dec 28, 2015

  2. JsonFreeman commented on Dec 28, 2015

    @JsonFreeman
    Jason Freeman (JsonFreeman)
    on Dec 28, 2015
    Contributor

    Remember to test this with ObjectBindingPattern as well, not just ArrayBindingPattern

  3. Mohamed Hegazy (mhegazy)
    added this to the TypeScript 2.0 milestone on Jan 7, 2016
  4. Mohamed Hegazy (mhegazy)
    assigned
    Vladimir Matveev (vladima)
    on Jan 7, 2016
  5. Mohamed Hegazy (mhegazy)
    modified the milestones: TypeScript 2.0, TypeScript 2.1 on Feb 24, 2016
  6. Mohamed Hegazy (mhegazy)
    added
    ES6Relates to the ES6 Spec
    and removed
    ES7Relates to the ES7 Spec
    on Aug 24, 2016
  7. Mohamed Hegazy (mhegazy)
    modified the milestones: TypeScript 2.1, on Sep 29, 2016
  8. Mohamed Hegazy (mhegazy)
    assigned
    Mohamed Hegazy (mhegazy)
    and unassigned
    Vladimir Matveev (vladima)
    on Mar 24, 2017

  9. ajafff commented on Jul 27, 2018

    @ajafff
    Klaus Meinhardt (ajafff)
    on Jul 27, 2018
    Contributor

    Daniel Rosenwasser (@DanielRosenwasser) there are actually two separate parts to this issue:

    • ParameterDeclaration and VariableDeclaration
      • only needs to remove the grammar check
      • downlevel emit already works as expected
    • allow BindingPattern for FunctionRestParameter
      • needs to remove the grammar check
      • currently there is no downlevel emit at all
  10. Klaus Meinhardt (ajafff)
    added 3 commits that reference this issue on Jul 27, 2018

    allow BindingPattern in BindingRestElement

    cafd643

    allow BindingPattern in BindingRestElement

    2ea3123

    allow BindingPattern in FunctionRestParameter

    d4f6b9b

  11. weswigham commented on Jan 14, 2019

    @weswigham
    Wesley Wigham (weswigham)
    on Jan 14, 2019
    Member

    Fixed by #26017

  12. Wesley Wigham (weswigham)
    closed this as completedon Jan 14, 2019
  13. Wesley Wigham (weswigham)
    unassigned
    Mohamed Hegazy (mhegazy)
    on Jan 14, 2019
  14. microsoft
    locked as resolved and limited conversation to collaborators on Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptES6Relates to the ES6 Spec

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions