const enum should allow "Infinity" as a valid name

    declare const enum CameraDeviceFocusMode {
        Normal = 0,
        TriggerAuto = 1,
        ContinuousAuto = 2,
        Infinity = 3, // <- error: An enum cannot have a numeric name
        Macro = 4
    }

This is intentional because Infinity is also a valid enum value; we disallow any name that might be a value because the lookup object only works if no names are values and no values are names.

Recommended fix is to just use Infinite instead of Infinity

What is the lookup object exactly? Using the name Infinity as a property key is completely valid in javascript by the way.

I missed that this enum was const. We don't need to enforce this rule for those.

(Lookup object, see http://stackoverflow.com/a/28818850/1704166)

Not enforcing that rule for const enum sounds great.

Approved even for non-const enums.

The suggested implementation was to skip any leading -, then see if the next (or first) character is a digit. Only names matching this rule should be subject to restriction. This should allow Infinity and NaN but still disallow names like 5.

Jordan Matthiesen (@jmatthiesen)

So what's the new rule now for numeric names? Same as before but make a special exception for "Infinity" and "NaN"?

Also Jordan Matthiesen (@jmatthiesen) asked about this a while back.

Same as before but make a special exception for "Infinity" and "NaN"?

Correct (as well as -Infinity)

Ryan Cavanaugh (@RyanCavanaugh)

Ryan Cavanaugh (@RyanCavanaugh) A JavaScript identifier must start with a letter, underscore (_), or dollar sign ($);. So, I think -Infinity is invalid.

Enum members need not be identifiers - they can be quoted much like the property names in object literals

Reported here too #3572

Navigation Menu

Repository navigation

const enum should allow "Infinity" as a valid name #6153

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

const enum should allow "Infinity" as a valid name #6153

Description

Activity

RyanCavanaugh commented on Dec 18, 2015

the-reality-engineer commented on Dec 18, 2015

RyanCavanaugh commented on Dec 18, 2015

RyanCavanaugh commented on Dec 18, 2015

the-reality-engineer commented on Dec 18, 2015

RyanCavanaugh commented on Jan 5, 2016

DanielRosenwasser commented on Jan 5, 2016

RyanCavanaugh commented on Jan 5, 2016

YuichiNukiyama commented on Mar 21, 2016

RyanCavanaugh commented on Mar 21, 2016

jbondc commented on May 9, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions