Repository navigation
Function parameter hover info is inconsistent between contexts #59219
Description
🔎 Search Terms
“hover”
🕗 Version & Regression Information
- This changed between versions 5.4 and 5.5
⏯ Playground Link
💻 Code
// User defined inside MDX files. We don’t control this.
type Props = {
someProp: string
}
// Internal helper type.
type MDXContentProps = Props & {components?: {}}
function MDXContent(props: {readonly [K in keyof MDXContentProps]: MDXContentProps[K]}) {
// ^?
// The types of props is pretty when hovering over props
}
MDXContent
// ^?
// The type of props is ugly when hovering over MDXContent
// Can we make this pretty as well? Preferably without introducing intermediate helper types.🙁 Actual behavior
Hovering over MDXContent shows the type of the props as written.
🙂 Expected behavior
Hovering over MDXContent shows a pretty formatted type of the props, just like TypeScript 5.4.
Additional information about the issue
I initially asked for help on Twitter to prettify this, not realizing this was a regression in TypeScript 5.5.
Later in the thread I was asked to report this bug.
Activity
jakebailey commentedon Jul 10, 2024
Bisects to #58078, though reverting it does not seem to actually change this behavior back.
Note that we more or less always want to be writing declarations back as they were written, as that's an invariant to make
isolatedDeclarationswork. Hover uses the same logic, but at some level this is related to #59029 and whether or not we need a hover mode which tries to do this "prettification".