Repository navigation
typeof with identically named type and value causes invalid .d.ts outputΒ #58390
Description
π Search Terms
type, value, .d.ts, circular, circularity, invalid, output, declaration
π Version & Regression Information
- This changed between versions 5.4 and 5.5
β― Playground Link
π» Code
export const descriptions = {
foo: "bar"
}
export type descriptions = typeof descriptionsπ Actual behavior
Actual .d.ts output:
export declare const descriptions: typeof descriptions;
export type descriptions = typeof descriptions;π Expected behavior
Expected .d.ts output:
export declare const descriptions: {
foo: string;
};
export type descriptions = typeof descriptions;Additional information about the issue
No response
Activity
Andarist commentedon May 1, 2024
Bisects to #57772
ssalbdivad commentedon May 2, 2024
Ryan Cavanaugh (@RyanCavanaugh) Is this not worth patching into TS 5.5?
Given how easy this is to repro, I'd assume this would occur often in the wild.
Issues like this that are only exposed in build output are also particularly insidious because most library authors don't explicitly check their build output, and most consumers use
skipLibCheck, which would result in the affected type silently resolving toany.patroza commentedon May 2, 2024
This would be quite a disaster especially considering this only occurs in the .d.ts which for libraries are often generated just before publishing.
mikearnaldi commentedon May 2, 2024
Following as Effect may be affected
mikearnaldi commentedon May 2, 2024
Given that this was introduced before release wouldn't it be a better strategy to revert the commit that introduced the bug and defer that commit to 5.6? It feels a bit odd to introduce a bug, recognize that it is a bug and defer the fix till a further version. I would understand the choice if this didn't came up pre-release
datner commentedon May 2, 2024
Hmm this matches a ton of common behavior, even the humble
as const"enum" is affected.This being broked^
though this works fine:
hmmmm
RyanCavanaugh commentedon May 2, 2024
Yeah, good points all around