[NewErrors] 5.5.0-dev.20240414 vs 5.4.5

The following errors were reported by 5.5.0-dev.20240414, but not by 5.4.5
Pipeline that generated this bug
Logs for the pipeline run
File that generated the pipeline

This run considered 800 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 499 of 800 visited repos

Outcome	Count
Detected interesting changes	26
Detected no interesting changes	473
Git clone failed	6
Package install failed	85
Project-graph error in old TS	9
Too many errors in old TS	192
Unknown failure	9

Investigation Status

Repo	Errors	Outcome
adobe/react-spectrum	1	#56902
aidenybai/million	1	#56902
alangpierce/sucrase	2	#57847 + 9998 = new error
ardatan/graphql-tools	1	`suppressImplicitAnyIndexErrors` removed
ariakit/ariakit	4	`ts-expect-error` on a bug 😎
bitwarden/clients	2	predicate inference broke class subtyping
Chocobozzz/PeerTube	1	#57847, appears to be bug in the project code (?)
conventional-changelog/conventional-changelog	1	#57549, exact details unclear so far
framer/motion	1	#57847 detects an implicit coercion that was previously unnoticed
growthbook/growthbook	1	#57847 caused an `any` to now be narrowed to `Function`
heyxyz/hey	5
highcharts/highcharts	6	`keyofStringsOnly` removed
ionic-team/stencil	1	Predicate inference identifies likely bug
jupyterlab/jupyterlab	2	#57681 (don't emit reference directives)
keplergl/kepler.gl	1	Doesn't build on Windows. Likely #57681
LokerL/tts-vue	1	`suppressImplicitAnyIndexErrors` removed
microsoft/playwright	1	This monorepo isn't building in 5.4, skipping
microsoft/vscode	1	vscode team will investigate
misskey-dev/misskey	4	predicate inference broke subtyping
outline/outline	1	`suppressImplicitAnyIndexErrors` removed
sequelize/sequelize	1	Unused `ts-expect-error`, seems good
strapi/strapi	12	Monorepo failed to build in 5.4, skipping
t3-oss/create-t3-app	1	`importsNotUsedAsValues` removed
tailwindlabs/headlessui	3
TanStack/router	2	Monorepo doesn't build in 5.4, skipping
tweenjs/tween.js	1	`importsNotUsedAsValues` removed

adobe/react-spectrum

5 of 10 projects failed to build with the old tsc and were ignored

packages/@spectrum-icons/illustrations/tsconfig.types.json

error TS2345: Argument of type '{ style: string; minimumFractionDigits: number; maximumFractionDigits: number; locale: string; numberingSystem: string; currency?: string; currencyDisplay?: keyof Intl.NumberFormatOptionsCurrencyDisplayRegistry; ... 13 more ...; trailingZeroDisplay: "auto" | "stripIfInteger"; }' is not assignable to parameter of type 'NumberFormatOptions'.
- packages/@internationalized/number/src/NumberParser.ts#L171
- packages/@internationalized/number/src/NumberParser.ts#L171

aidenybai/million

3 of 4 projects failed to build with the old tsc and were ignored

website/tsconfig.json

error TS2322: Type '{ plugins: { legend: { display: boolean; }; }; indexAxis: "y"; scales: { x: { max: number; ticks: { format: { style: string; minimumFractionDigits: number; maximumFractionDigits: number; }; }; }; }; }' is not assignable to type '_DeepPartialObject<CoreChartOptions<"bar"> & ElementChartOptions<"bar"> & PluginChartOptions<"bar"> & DatasetChartOptions<"bar"> & ScaleChartOptions<...> & BarControllerChartOptions>'.
- website/components/chart.tsx#L81

alangpierce/sucrase

4 of 18 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2367: This comparison appears to be unintentional because the types 'JSXRole.NoChildren' and 'JSXRole.KeyAfterPropSpread' have no overlap.
- src/parser/plugins/jsx/index.ts#L258

src/tsconfig.json

error TS2367: This comparison appears to be unintentional because the types 'JSXRole.NoChildren' and 'JSXRole.KeyAfterPropSpread' have no overlap.
- src/parser/plugins/jsx/index.ts#L258

ardatan/graphql-tools

tsconfig.json

error TS5102: Option 'suppressImplicitAnyIndexErrors' has been removed. Please remove it from your configuration.
- tsconfig.json#L19

ariakit/ariakit

1 of 6 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- packages/ariakit-react-core/src/utils/store.tsx#L138

website/tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- packages/ariakit-react-core/src/utils/store.tsx#L138

packages/ariakit-react-core/tsconfig.build.json

error TS2578: Unused '@ts-expect-error' directive.
- packages/ariakit-react-core/src/utils/store.tsx#L138

packages/ariakit-react/tsconfig.build.json

error TS2578: Unused '@ts-expect-error' directive.
- packages/ariakit-react-core/src/utils/store.tsx#L138

bitwarden/clients

8 of 40 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2416: Property 'filterProvider' in type 'TwoFactorSetupComponent' is not assignable to the same property in base type 'TwoFactorSetupComponent'.
- apps/web/src/app/admin-console/organizations/settings/two-factor-setup.component.ts#L80

apps/web/tsconfig.json

error TS2416: Property 'filterProvider' in type 'TwoFactorSetupComponent' is not assignable to the same property in base type 'TwoFactorSetupComponent'.
- apps/web/src/app/admin-console/organizations/settings/two-factor-setup.component.ts#L80

Chocobozzz/PeerTube

4 of 11 projects failed to build with the old tsc and were ignored

client/tsconfig.json

error TS2352: Conversion of type 'string' to type 'FormReactiveErrors' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
- client/src/app/shared/shared-forms/form-validator.service.ts#L59

conventional-changelog/conventional-changelog

2 of 14 projects failed to build with the old tsc and were ignored

packages/conventional-changelog-writer/tsconfig.json

error TS2345: Argument of type 'SortBy<PickStrings<Commit>>' is not assignable to parameter of type 'string | string[] | Comparator<PickStrings<Commit>> | undefined'.
- packages/conventional-changelog-writer/src/options.ts#L80

framer/motion

3 of 4 projects failed to build with the old tsc and were ignored

packages/framer-motion/tsconfig.json

error TS2322: Type 'string' is not assignable to type 'number'.
- packages/framer-motion/src/projection/animation/mix-values.ts#L75

growthbook/growthbook

6 of 10 projects failed to build with the old tsc and were ignored

packages/back-end/tsconfig.json

error TS2345: Argument of type 'Function' is not assignable to parameter of type '(req: Request<any, any, any, ParsedQs, Record<string, any>>, res: Response<any, Record<string, any>, number>, next: NextFunction) => void | Promise<...>'.
- packages/back-end/src/routers/wrapController.ts#L17

heyxyz/hey

2 of 13 projects failed to build with the old tsc and were ignored

apps/web/tsconfig.json

error TS2345: Argument of type 'import("/mnt/ts_downloads/_/m/hey/node_modules/.pnpm/@apollo+client@3.9.11_@types+react@18.2.77_graphql@16.8.1_react-dom@18.2.0_react@18.2.0/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink' is not assignable to parameter of type 'import("/mnt/ts_downloads/_/m/hey/node_modules/.pnpm/@apollo+client@3.9.11_graphql-ws@5.16.0_graphql@16.8.1/node_modules/@apollo/client/link/core/ApolloLink").ApolloLink'.
- apps/web/src/components/Common/Providers/index.tsx#L25
error TS2322: Type '(cache: ApolloCache<any>) => void' is not assignable to type 'MutationUpdaterFunction<AddReactionMutation, Exact<{ request: ReactionRequest; }>, DefaultContext, ApolloCache<any>>'.
- apps/web/src/components/Publication/Actions/Like.tsx#L80
error TS2322: Type '(cache: ApolloCache<any>) => void' is not assignable to type 'MutationUpdaterFunction<RemoveReactionMutation, Exact<{ request: ReactionRequest; }>, DefaultContext, ApolloCache<any>>'.
- apps/web/src/components/Publication/Actions/Like.tsx#L95
error TS2322: Type '(cache: ApolloCache<any>) => void' is not assignable to type 'MutationUpdaterFunction<PeerToPeerRecommendMutation, Exact<{ request: PeerToPeerRecommendRequest; }>, DefaultContext, ApolloCache<...>>'.
- apps/web/src/components/Shared/Profile/P2PRecommendation.tsx#L69
error TS2322: Type '(cache: ApolloCache<any>) => void' is not assignable to type 'MutationUpdaterFunction<PeerToPeerUnrecommendMutation, Exact<{ request: PeerToPeerRecommendRequest; }>, DefaultContext, ApolloCache<...>>'.
- apps/web/src/components/Shared/Profile/P2PRecommendation.tsx#L83

highcharts/highcharts

19 of 26 projects failed to build with the old tsc and were ignored

ts/tsconfig.json

error TS5102: Option 'keyofStringsOnly' has been removed. Please remove it from your configuration.
- ts/tsconfig.json#L134 in ts/tsconfig.json

ts/masters-es5/tsconfig.json

error TS5102: Option 'keyofStringsOnly' has been removed. Please remove it from your configuration.
- Project Scope in ts/masters-es5/tsconfig.json

ts/masters-datagrid/tsconfig.json

error TS5102: Option 'keyofStringsOnly' has been removed. Please remove it from your configuration.
- Project Scope in ts/masters-datagrid/tsconfig.json

ts/masters-dashboards/tsconfig.json

error TS5102: Option 'keyofStringsOnly' has been removed. Please remove it from your configuration.
- Project Scope in ts/masters-dashboards/tsconfig.json

ts/DataGrid/tsconfig.json

error TS5102: Option 'keyofStringsOnly' has been removed. Please remove it from your configuration.
- Project Scope in ts/DataGrid/tsconfig.json

ts/Dashboards/tsconfig.json

error TS5102: Option 'keyofStringsOnly' has been removed. Please remove it from your configuration.
- Project Scope in ts/Dashboards/tsconfig.json

ionic-team/stencil

34 of 38 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2367: This comparison appears to be unintentional because the types 'number' and 'string' have no overlap.
- src/runtime/proxy-component.ts#L157

jupyterlab/jupyterlab

42 of 58 projects failed to build with the old tsc and were ignored

galata/tsconfig.json

error TS2503: Cannot find namespace 'jest'.
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L29 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L36 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L40 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L44 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L48 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L52 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L56 in packages/notebook/tsconfig.json

galata/extension/tsconfig.json

error TS2503: Cannot find namespace 'jest'.
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L29 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L36 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L40 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L44 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L48 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L52 in packages/notebook/tsconfig.json
- file:///mnt/ts_downloads/_/m/jupyterlab/packages/services/lib/testutils.d.ts#L56 in packages/notebook/tsconfig.json

keplergl/kepler.gl

13 of 17 projects failed to build with the old tsc and were ignored

src/actions/tsconfig.production.json

error TS2307: Cannot find module '@deck.gl/core/lib/deck' or its corresponding type declarations.
- src/actions/src/vis-state-actions.ts#L5

microsoft/playwright

4 of 15 projects failed to build with the old tsc and were ignored

packages/html-reporter/tsconfig.json

error TS1192: Module '"/mnt/ts_downloads/_/m/playwright/node_modules/@zip.js/zip.js/index"' has no default export.
- packages/html-reporter/src/index.tsx#L18

microsoft/vscode

7 of 54 projects failed to build with the old tsc and were ignored

src/tsconfig.monaco.json

error TS2322: Type '<T, TChange>(o: IObservable<T, TChange>) => boolean' is not assignable to type '<T, TChange>(observable: IObservable<T, TChange>) => this is { change: TChange; }'.
- src/vs/base/common/observableInternal/autorun.ts#L256
- src/vs/base/common/observableInternal/derived.ts#L341

misskey-dev/misskey

6 of 13 projects failed to build with the old tsc and were ignored

packages/backend/tsconfig.json

error TS2322: Type '() => true' is not assignable to type '() => this is IJust<T>'.
- packages/backend/src/misc/prelude/maybe.ts#L16
error TS2322: Type '() => false' is not assignable to type '() => this is IJust<T>'.
- packages/backend/src/misc/prelude/maybe.ts#L23

packages/backend/test/tsconfig.json

error TS2322: Type '() => true' is not assignable to type '() => this is IJust<T>'.
- packages/backend/src/misc/prelude/maybe.ts#L16
error TS2322: Type '() => false' is not assignable to type '() => this is IJust<T>'.
- packages/backend/src/misc/prelude/maybe.ts#L23

outline/outline

tsconfig.json

error TS5102: Option 'suppressImplicitAnyIndexErrors' has been removed. Please remove it from your configuration.
- tsconfig.json#L26

sequelize/sequelize

12 of 16 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.json

error TS2578: Unused '@ts-expect-error' directive.
- packages/core/src/decorators/shared/model.ts#L136
- packages/core/src/model-definition.ts#L1011

strapi/strapi

76 of 118 projects failed to build with the old tsc and were ignored

t3-oss/create-t3-app

1 of 6 projects failed to build with the old tsc and were ignored

www/tsconfig.json

error TS5102: Option 'importsNotUsedAsValues' has been removed. Please remove it from your configuration.
- www/tsconfig.json#L8

tailwindlabs/headlessui

1 of 5 projects failed to build with the old tsc and were ignored

packages/@headlessui-vue/tsconfig.json

error TS2527: The inferred type of 'disposables' references an inaccessible 'this' type. A type annotation is necessary.
- packages/@headlessui-vue/src/utils/disposables.ts#L5

packages/@headlessui-react/tsconfig.json

error TS2527: The inferred type of 'useDisposables' references an inaccessible 'this' type. A type annotation is necessary.
- packages/@headlessui-react/src/hooks/use-disposables.ts#L8
error TS2527: The inferred type of 'disposables' references an inaccessible 'this' type. A type annotation is necessary.
- packages/@headlessui-react/src/utils/disposables.ts#L17

TanStack/router

59 of 64 projects failed to build with the old tsc and were ignored

packages/react-cross-context/tsconfig.json

error TS2769: No overload matches this call.
- packages/react-cross-context/vite.config.ts#L6
error TS2345: Argument of type 'UserConfig & Promise<UserConfig> & (UserConfigFnObject & UserConfigExport)' is not assignable to parameter of type 'never'.
- packages/react-cross-context/vite.config.ts#L10

tweenjs/tween.js

tsconfig.json

error TS5102: Option 'importsNotUsedAsValues' has been removed. Please remove it from your configuration.
- tsconfig.json#L15

Will Martin (@willmartian)

bitwarden/clients has this setup

  // Base class
  protected filterProvider(type: TwoFactorProviderType) {
    return type !== TwoFactorProviderType.OrganizationDuo;
  }

  // Derived class
  protected filterProvider(type: TwoFactorProviderType) {
    return type === TwoFactorProviderType.OrganizationDuo;
  }

So type predicate inference broke the class subtyping. They just need to add ): boolean to the base class method. FYi Will Martin (@willmartian) Shane Melton (@shane-melton) Matt Gibson (@MGibson1)

sucrase got broken by #57847, it looks like this

  state.tokens[initialTokenIndex].jsxRole = JSXRole.NoChildren;
                 // this initialization gets CFA'd now
  let numExplicitChildren = 0;
  const isSelfClosing = jsxParseOpeningElement(initialTokenIndex);
  if (!isSelfClosing) {
    nextJSXExprToken();
    while (true) {
      switch (state.type) {
        case tt.jsxTagStart:
          nextJSXTagToken();
          if (match(tt.slash)) {
            nextJSXTagToken();
            jsxParseClosingElement();
            // Key after prop spread takes precedence over number of children,
            // since it means we switch to createElement, which doesn't care
            // about number of children.
            if (state.tokens[initialTokenIndex].jsxRole !== JSXRole.KeyAfterPropSpread) {
                                                     // ^^^
      //                                      apppears impossible now

Chocobozzz/Peertube has a similar thing:

    for (const name of objectKeysTyped(formToBuild)) {
      formErrors[name] = ''

      const field = formToBuild[name]
      if (this.isRecursiveField(field)) {
        this.updateFormGroup(
          // FIXME: typings
          (form as any)[name],
          formErrors[name] as FormReactiveErrors,

Though it looks like a legit error in this case unless isRecursiveField actually has side effects (???)

framer/motion does a compound coercion which we now detect:

            target[borderLabel] = Math.max(
                mixNumber(
                    asNumber(followRadius),
                    asNumber(leadRadius),
                    progress
                ),
                0
            )

            if (percent.test(leadRadius) || percent.test(followRadius)) {
                target[borderLabel] += "%"
            }

[NewErrors] 5.5.0-dev.20240414 vs 5.4.5 #58189

Description

Investigation Status

Activity

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

1 remaining item

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

typescript-bot commented on Apr 14, 2024

RyanCavanaugh commented on Apr 18, 2024

RyanCavanaugh commented on Apr 18, 2024

RyanCavanaugh commented on Apr 18, 2024

RyanCavanaugh commented on Apr 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions