TS: duplicated imports in this case

Steps to Reproduce:

in our sources have a TS file that uses import { watchFile } from 'fs';
somewhere begin to use unwatchFile
use quick fix to add import
pick "Add import from 'fs'"

=> 🐛 you get a second import

import { watchFile } from 'fs';
import { unwatchFile } from 'fs';

Benjamin Pasero (@bpasero)

I'm working on a similar issue that duplicates import for 'move to file' and I tried to check if this is the same issue. However, the repro that I was trying out does not give me an error. Benjamin Pasero (@bpasero) please help me understand if this is similar to what you were trying out.
This is what I tried:

// @Filename: /a.ts
export const t = 0;
export const t2 = 0;

// @Filename: /b.ts
import {  t  } from "./a";

const y = t + 1;
const z = t2/**/ + 1;

Used quick fix at /**/ to add import from "./a" and it resulted in import { t, t2 } from "./file1";

navya9singh

navya9singh my steps repro in the vscode sources if you open src/vs/platform/files/node/watcher/baseWatcher.ts and do the suggested change there.

Navigation Menu

Repository navigation

TS: duplicated imports in this case #57726

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

TS: duplicated imports in this case #57726

Description

Activity

navya9singh commented on Mar 11, 2024

bpasero commented on Mar 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions