You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
console.trace definition is invalid in /lib/lib.dom.d.ts #5433
Mohamed Hegazy (@mhegazy), thanks for your reply! It was the first thing i've done. :) But transpiling via gulp-typescript still throws warnings. Though i've fixed every interface i could find.
Anyway, i supposed this issue would be useful for the typescript project.
Mohamed Hegazy (@mhegazy) , oh just the same as i've written above.
Although i've optioned gulp-typescript to use TS from require('typescript'). And i've searched-and-replaced every d.ts file around typescript modules. Have no idea why it's still not satisfied. but errors don't block building process. so i move on.
Activity
mhegazy commentedon Oct 28, 2015
Ivan Pesochenko (@wallride) for now you can reopen the interface locally and define the missing signature as such:
wallride commentedon Oct 29, 2015
Mohamed Hegazy (@mhegazy), thanks for your reply! It was the first thing i've done. :) But transpiling via gulp-typescript still throws warnings. Though i've fixed every interface i could find.
Anyway, i supposed this issue would be useful for the typescript project.
mhegazy commentedon Oct 29, 2015
just out of curiosity, what are the errors you were getting from gulp?
wallride commentedon Oct 29, 2015
Mohamed Hegazy (@mhegazy) , oh just the same as i've written above.
Although i've optioned gulp-typescript to use TS from require('typescript'). And i've searched-and-replaced every d.ts file around typescript modules. Have no idea why it's still not satisfied. but errors don't block building process. so i move on.
mhegazy commentedon Oct 29, 2015
but you do not need to replace the definition in lib.d.ts, you can just augment it. so in one of your files, just add the new definition.. here is what i mean in the playground: http://www.typescriptlang.org/Playground#src=interface%20Console%20%7B%0D%0A%20%20%20%20trace(...args%3A%20any%5B%5D)%3A%20void%3B%0D%0A%7D%0D%0A%0D%0Aconsole.trace(%22message%22)%3B%20%2F%2F%20OK%0D%0A
wallride commentedon Oct 30, 2015
Mohamed Hegazy (@mhegazy) Yes, that is a some kind of solution. Thanks!
And declaration in lib.d.ts should be fixed anyway, i suppose :)
mhegazy commentedon Oct 30, 2015
yup. the bug is open, should be fixed in TS1.8, but until then, no need to keep getting errors in your compilation.
mhegazy commentedon Dec 8, 2015
PRs are welcomed. here is some documentation for adding new types to lib.d.ts: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes