You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The behavior is intentional to avoid having misspelled compiler options go unchecked.
In this specific case, we can put pack the flag as "known", but not require it, for a release or so, until all tools have moved on.
Before i do this, i would like to know what is the issue here, Basarat Ali Syed (@basarat) any idea why this would be an issue with atom? would that be something fixed by taking latest from master of release-1.7 branch.
would that be something fixed by taking latest from master of release-1.7 branch.
Yes definitely, mostly waiting on two bugs (linked here TypeStrong/atom-typescript#663) : #5278 (labeled as a bug needing fixing) & #5110 (not reproduced cause I don't have the test files ... so will probably update even without this)
The behavior is intentional to avoid having misspelled compiler options go unchecked.
The default behaviour yes, but this is a request for a flag to circumvent this behaviour.
Even if this specific case is fixed, it will probably pop up again when other flags are removed. Having a flag that can be set in those cases would make it easier for everyone. You doesn't need to keep "ghost flags" around and we can workaround this kind of problems instead of rolling back the version.
I understand the issue, but i do not think the proposed solution of a new flag solves it, it just hides the problem. We will get #5278 fixed today, and that will unblock Basarat Ali Syed (@basarat). and moving on will take a a more gradual approach to removing flags to make sure non one runs into this again.
We keep the original issue in mind in the future. we should have a better deprication story for flags. sorry for the trouble. but i believe now migrating to latest atom-typescript safely.
Activity
mhegazy commentedon Oct 26, 2015
The behavior is intentional to avoid having misspelled compiler options go unchecked.
In this specific case, we can put pack the flag as "known", but not require it, for a release or so, until all tools have moved on.
Before i do this, i would like to know what is the issue here, Basarat Ali Syed (@basarat) any idea why this would be an issue with atom? would that be something fixed by taking latest from master of release-1.7 branch.
basarat commentedon Oct 26, 2015
Yes definitely, mostly waiting on two bugs (linked here TypeStrong/atom-typescript#663) : #5278 (labeled as a bug needing fixing) & #5110 (not reproduced cause I don't have the test files ... so will probably update even without this)
Pajn commentedon Oct 26, 2015
The default behaviour yes, but this is a request for a flag to circumvent this behaviour.
Even if this specific case is fixed, it will probably pop up again when other flags are removed. Having a flag that can be set in those cases would make it easier for everyone. You doesn't need to keep "ghost flags" around and we can workaround this kind of problems instead of rolling back the version.
mhegazy commentedon Oct 26, 2015
I understand the issue, but i do not think the proposed solution of a new flag solves it, it just hides the problem. We will get #5278 fixed today, and that will unblock Basarat Ali Syed (@basarat). and moving on will take a a more gradual approach to removing flags to make sure non one runs into this again.
chore(typescript) update to latest
mhegazy commentedon Nov 13, 2015
We keep the original issue in mind in the future. we should have a better deprication story for flags. sorry for the trouble. but i believe now migrating to latest atom-typescript safely.