Skip to content

#53258 breaks ckeditor__ckeditor5-upload on DT #53459

Closed

Description

Here is a small repro based on that package:

export default class FileReader implements Observable {
    set(option: Record<string, unknown>): void;
    set(name: string, value: unknown): void;
}
export interface Observable {
    set(...args: [option: Record<string, unknown>] | [name: string, value: unknown] | [name: string]): void;
}

Activity

  1. jakebailey commented on Mar 23, 2023

    @jakebailey
    Member

    I might be wrong but the second overload is already an error in TS 5.0; is that intentional?

  2. jakebailey commented on Mar 23, 2023

    @jakebailey
    Member

    Oh, nevermind; it's missing declare.

  3. jakebailey commented on Mar 23, 2023

    @jakebailey
    Member

    I think I may just revert my PR and try and go for fixing #53398 instead.

  4. locked as resolved and limited conversation to collaborators on Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugA bug in TypeScriptFix AvailableA PR has been opened for this issueRecent RegressionThis is a new regression just found in the last major/minor version of TypeScript.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions