Activity

1. jakebailey commented on Feb 19, 2023

   

   Jake Bailey (jakebailey)

   on Feb 19, 2023

   Last edited by jakebailey

   Member

   More actions

   TS 5.0 also adds support for d.ts files for arbitrary extensions: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#allowarbitraryextensions

   This seems pretty similar to what you're trying to do in your plugin, in that one can define a styles.d.css.ts file and provide types. It's possible that you could implement it by providing a d.ts and d.ts.map file via a plugin (though, I'm less familiar with how much can be proxied there). That or, use some sort of codegen that puts the d.ts files next to the css files, that way they can be used outside of the LS too.
2. mrmckeb commented on Feb 20, 2023

   

   Brody McKee (mrmckeb)

   on Feb 20, 2023

   Last edited by mrmckeb

   Author

   More actions

   Thanks Jake Bailey (@jakebailey), I missed that allowArbitraryExtensions was coming and that looks really interesting.

   Do you know who might be able to help with information around proxying other methods needed to read/process non-TS files? Perhaps a better alternative to using the now immutable createLanguageServiceSourceFile and updateLanguageServiceSourceFile methods?

   For context, this plugin has around 200k+ weekly downloads, which I think (from a quick search) makes it one of the most popular language service plugins. It allows users to have type information from CSS (including Less, Sass, etc) without needing to watch and generate DTS files for those files in a separate process.
3. jakebailey commented on Feb 21, 2023

   

   Jake Bailey (jakebailey)

   on Feb 21, 2023

   Last edited by jakebailey

   Member

   More actions

   Ron Buckton (@rbuckton) has suggested that you could provide styles.d.css.ts via the host, but Sheetal Nandi (@sheetalkamat) may also have ideas.

   I'm planning on trying to go through as many plugins and patchers as possible to get a handle on which APIs people are trying to patch. I was hoping that the lack of feedback regarding this meant that it wasn't so widespread (this change happened circa November 2022), but, it seems like people are coming out of the woodwork now that the RC is approaching (which is unfortunate given a "fix" for this on the TS side is likely to be nontrivial).
4. jakebailey commented on Feb 22, 2023

   

   Jake Bailey (jakebailey)

   on Feb 22, 2023

   Last edited by jakebailey

   Member

   More actions

   I've been working on that collected "ts patchers" list and stumbled upon Vue's LS plugin; they appear to proxy the host to provide similar functionality, so I believe that it's possible to do something like you already do within the current API:

   • https://github.com/vuejs/language-tools/blob/master/packages/vue-language-core/src/languageModule.ts#L46
   • https://github.com/volarjs/volar.js/blob/master/packages/language-core/src/languageContext.ts#L16
5. sheetalkamat commented on Feb 22, 2023

   

   Sheetal Nandi (sheetalkamat)

   on Feb 22, 2023

   Member

   More actions

   Sorry i missed this notification yesterday.
   You would want to proxy following methods on languageServiceHost thats passed in through plugin create info.

   getScriptKind?(fileName: string): ScriptKind`
   getScriptVersion(fileName: string): string;
   getScriptSnapshot(fileName: string): IScriptSnapshot | undefined;
   
6. mrmckeb commented on Feb 24, 2023

   

   Brody McKee (mrmckeb)

   on Feb 24, 2023

   Author

   More actions

   Thanks so much for all of the detail Jake Bailey (@jakebailey), and for the additional info Sheetal Nandi (@sheetalkamat).

   This is an unsponsored project, so I'll take a look at migrating to these APIs over the weekend!
7. Ryan Cavanaugh (RyanCavanaugh)

   added

   QuestionAn issue which isn't directly actionable in codeAn issue which isn't directly actionable in code

   on Feb 24, 2023
8. TypeScript Bot (typescript-bot)

   closed this as completedon Feb 26, 2023
9. typescript-bot commented on Feb 26, 2023

   

   TypeScript Bot (typescript-bot)

   on Feb 26, 2023

   Contributor

   More actions

   This issue has been marked as 'Question' and has seen no recent activity. It has been automatically closed for house-keeping purposes. If you're still waiting on a response, questions are usually better suited to stackoverflow or the TypeScript Discord community.
10. mrmckeb commented on Mar 11, 2023

    

    Brody McKee (mrmckeb)

    on Mar 11, 2023

    Last edited by mrmckeb

    Author

    More actions

    Thanks again for the help on this issue. I managed to get it working this weekend, and feeling very relieved!

    mrmckeb/typescript-plugin-css-modules#211
11. jakebailey commented on Mar 13, 2023

    

    Jake Bailey (jakebailey)

    on Mar 13, 2023

    Member

    More actions

    Glad you got it working. I left some comments on the PR which you may want to look at; in general, plugins should not import typescript, only ever using the ts value passed into init, otherwise they will be different objects entirely and may cause oddities.

    ❤️React with ❤️1Reacted by Brody McKee
12. yoyo930021 commented on Apr 17, 2023

    

    yoyoIU (yoyo930021)

    on Apr 17, 2023

    Last edited by yoyo930021

    More actions

    Sorry for the disturbance, I am the current primary maintainer of Vetur. Vetur now relies on createLanguageServiceSourceFile to inject the export default object wrapped with Vue.extends into each Vue SFC. This layer is added directly to the AST and is set to not exist in the document through a hack.

    If we want to change to the method mentioned above, we need to switch to a text-based approach combined with sourcemaps, which would be equivalent to rewriting the entire project. I would like to confirm if there are any similar hackable methods available? Otherwise, Vetur might have to give up on continuing support for TypeScript 5 and beyond.
13. jakebailey commented on Apr 17, 2023

    

    Jake Bailey (jakebailey)

    on Apr 17, 2023

    Last edited by jakebailey

    Member

    More actions

    I am assuming you're referring to: https://github.com/vuejs/vetur/blob/96aaa707f8ca629f0883c57a47adb0e58995936d/server/src/services/typescriptService/preprocess.ts

    If I'm reading this correctly, you're calling the original createLanguageServiceSourceFile, then using its AST, modifying it, reprinting it, and then reparsing it, correct?

    In which case, can you just do the same thing but skip the final re-parse step and return source in getScriptSnapshot? The only other bit I can see is that it automagically adds imports, which I think can be done in other ways, either also by source modification, or by using a global d.ts file which declares these for you. I know that volar does some of this.

    Though, I'm a bit confused; I thought vetur was deprecated in favor of volar, which I think is working with TS 5.0?
14. yoyo930021 commented on Apr 18, 2023

    

    yoyoIU (yoyo930021)

    on Apr 18, 2023

    Last edited by yoyo930021

    More actions

    I am assuming you're referring to: https://github.com/vuejs/vetur/blob/96aaa707f8ca629f0883c57a47adb0e58995936d/server/src/services/typescriptService/preprocess.ts

    If I'm reading this correctly, you're calling the original createLanguageServiceSourceFile, then using its AST, modifying it, reprinting it, and then reparsing it, correct?

    In which case, can you just do the same thing but skip the final re-parse step and return source in getScriptSnapshot? The only other bit I can see is that it automagically adds imports, which I think can be done in other ways, either also by source modification, or by using a global d.ts file which declares these for you. I know that volar does some of this.

    Though, I'm a bit confused; I thought vetur was deprecated in favor of volar, which I think is working with TS 5.0?

    The main logic is in this line:
    https://github.com/vuejs/vetur/blob/96aaa707f8ca629f0883c57a47adb0e58995936d/server/src/services/typescriptService/preprocess.ts#L184
    It inserts additional AST and sets the AST's position to 0, so that TS will not generate messages at incorrect positions. If changed to use the getScriptSnapshot method, an extra sourcemap would be required to map the code position information back, which would be equivalent to rewriting the entire project.
    The rest of the logic is actually not that important.

    Volar is the new official Vue extension, but it mainly focuses on Vue 3 projects; Vetur now focuses on supporting older Vue 2 projects, with limited support for Vue 3 and only providing basic maintenance, without adding new features.
15. microsoft

    locked as resolved and limited conversation to collaborators on Oct 22, 2025