Repository navigation
[libdom] Allow Response / Request to be genericsΒ #52777
Description
Suggestion
π Search Terms
request, response, libdom, generic, generics, type parameters
β Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
β Suggestion
Similar to the FormData request by Wes Bos (@wesbos) in #43797, it would be great if the Request and Response globals could also accept generic type parameters.
This will become more relevant as more frameworks continue to increase their usage of these standard globals, also in Node.js.
Consider the following example of an App Route handler in Next.js (handling a POST request to an API route):
export async function POST(request: Request): Response {
const body = await request.json();
// ^? const body: any β
return new Response(JSON.stringify({
abc: 123, // β POST function return type cannot check type of response body object
}))
}What would be amazing would be something similar to this:
type RequestBody = { zzz: number };
type ResponseBody = { abc: number };
export async function POST(request: Request<RequestBody>): Response<ResponseBody> {
const body = await request.json();
// ^? const body: { zzz: number } β
return new Response(JSON.stringify({
abc: 123, // β
type checked
}))
}π Motivating Example
The second example in the Suggestion section above.
π» Use Cases
For typing the response body of API routes
Prior Art
@types/express:RequestandResponsetypes - which both accept a generic type parameter.- Next.js:
NextResponseaccepting generic parameters
Workaround
Response
Wasn't able to find a nice workaround for typing the body of a Response yet.
Request
Using Type Assertion / casting via as:
type RequestBody = { zzz: string };
export async function POST(request: Request) {
const body = await request.json() as RequestBody;Caveats
- Arguably, the
Requestbody is unknown until runtime, so this is better handled instead with Zod or some other runtime validation. But for quick/simple projects without this validation, it's nice to be able to type the request body type.
Activity
MartinJohns commentedon Feb 15, 2023
IMO the same reason applies here: #33037 (comment)
Same thing why
JSON.parse()is not generic.karlhorky commentedon Feb 20, 2023
JSON.parse()is only one part of the equation - the parsed request body. That is why I wrote the caveat in the issue above:Type checking the return value of a function (the
Responsepart of this proposal) is a statically analyzable way to enforce the response shapes of API handlers (eg. especially useful with the newResponse.json()static method) and does not have anything to do with the "JSON data off the wire" mentioned in your linked comment.k1eu commentedon Aug 31, 2024
Karl Horky (@karlhorky) You might like this. (I saw you on my TypedFormData package! :) I build a very small wrapper around fetch, Request and Response for this particular issues :)
Ofc it's fully compatible with regular interfaces. You can check it out here! https://github.com/k1eu/typed-request