Repository navigation
this within function typed as any when annotated with JSDoc #51868
Description
Bug Report
When function is annotated with JSDoc then even if the type explicitly specifies the type of this, the this is typed as any within the function. It seems to work in a *.ts file but not in *.js with JSDoc annotation.
Also it seems to be a regression (or intentional change) in 4.9.4.
🔎 Search Terms
jsdoc this any
🕗 Version & Regression Information
- This changed between versions 4.8.4 and 4.9.4
⏯ Playground Link
Stackblitz link is below but it doesn't reproduce there as it doesn't seem to support JSDoc well.
- Go to https://stackblitz.com/edit/bc4n2m?file=types.d.ts,index.ts,index.js,tsconfig.json&view=editor
- Download the project to hard drive
- Install dependencies with
npm ioryarn - Open project in VSCode and open file
index.js - Hover over
this.
💻 Code
index.js
/** @type {import('./types').Module} */
export default function SentryModule () {
return this.test()
}types.d.ts
interface ModuleThis {
foo: () => void;
}
export type Module = (this: ModuleThis) => void;🙁 Actual behavior
this has any type in TS 4.9.4
🙂 Expected behavior
this is correctly typed as ModuleThis as in TS 4.8.4.
Activity
rchl commentedon Dec 13, 2022
Note: The current version of VSCode might default to 4.8.4 version in which case the issue will not show up but it reproduces after switching to version of typescript from the project in the bottom right corner of the status bar.
andrewbranch commentedon Dec 19, 2022
This seems to be an issue specific to typing function declarations. If you switch to a variable declaration initialized to a function expression, it works:
But on the other hand, it’s not as if the annotation on the function declaration does nothing. Mismatched parameters errors as expected:
This inconsistency does seem like a bug.