Go-to-definition on await/yield should probably jump to the containing respective async function/generator #51223

Activity

1. Daniel Rosenwasser (DanielRosenwasser)

   added

   Help WantedYou can do thisYou can do this

   Good First IssueWell scoped, documented and has the green lightWell scoped, documented and has the green light

   Experience EnhancementNoncontroversial enhancementsNoncontroversial enhancements

   Domain: LS: Symbol NavigationRelates to go-to-definition, find-all-references, highlighting/occurrences.Relates to go-to-definition, find-all-references, highlighting/occurrences.

   on Oct 19, 2022
2. Daniel Rosenwasser (DanielRosenwasser)

   added this to the Backlog milestone on Oct 19, 2022
3. fatcerberus commented on Oct 19, 2022

   

   Bruce Pascoe (fatcerberus)

   on Oct 19, 2022

   Last edited by fatcerberus

   More actions

   I would expect GTD on await to jump to the async keyword of the containing function, in line with how e.g. VS C# intellisense highlights the async keyword (and incidentally, all the other awaits in the same function) when you place the cursor on an await.
4. DanielRosenwasser commented on Oct 19, 2022

   

   Daniel Rosenwasser (DanielRosenwasser)

   on Oct 19, 2022

   MemberAuthor

   More actions

   I guess maybe there's a catch with

   class Foo {
     /*END1*/public /*END2*/async yadda() {
       /*START*/await 10;
     }
   }

   I feel like the distance is not that big that it matters whether we pick END1 or END2. I could go both ways.

   Thinking about it some more, I wonder if it makes sense to always make the go-to-definition succeed, even if the containing function isn't async or a generator. If you're in the error case, it can be helpful to jump to whichever function contains the keyword.
5. DanielRosenwasser commented on Oct 19, 2022

   

   Daniel Rosenwasser (DanielRosenwasser)

   on Oct 19, 2022

   Last edited by DanielRosenwasser

   MemberAuthor

   More actions

   Also, another fun test case based on the "should not fail" strategy".

   function* gen() {
     /*END(???)*/class C { [/*START*/yield 10]() {} }
   }
6. Nathan Shively-Sanders (sandersn)

   closed this as completedin #51838on Dec 20, 2022