Skip to content

Evaluate inference changes in reselect due to tuple type mapping changes #50870

Closed

Description

In #50831, we fixed a bug around ensuring that optional tuple elements always contain a missing/undefined type, even when a mapped type tries to remove them.

However, this had some impact on 2 calls to reduxjs/reselect. Occasionally undefined can spoil inference results, but it's not clear where that might be taking place in the library.

Activity

  1. added
    Needs More InfoThe issue still hasn't been fully clarified
    Needs ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.
    Needs InvestigationThis issue needs a team member to investigate its status.
    on Sep 21, 2022
  2. ahejlsberg commented on Sep 21, 2022

    @ahejlsberg
    Member

    See here for a simplified version of the MergeParameters type that works with TS 4.7 and later.

  3. markerikson commented on Nov 4, 2022

    @markerikson

    FYI I was able to successfully use the MergeParameters type from Anders, although the publishing step to make the package work from 4.2...4.9 was awkward:

    reduxjs/reselect#587

  4. Andarist commented on Aug 26, 2023

    @Andarist
    Contributor

    This investigation was resolved. reselect shipped the type provided by Anders. I think that this issue could be closed now :) cc Jake Bailey (@jakebailey)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Needs InvestigationThis issue needs a team member to investigate its status.Needs More InfoThe issue still hasn't been fully clarifiedNeeds ProposalThis issue needs a plan that clarifies the finer details of how it could be implemented.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions