[NewErrors] 4.7.1-rc vs 4.6.4

The following errors were reported by 4.7.1-rc, but not by 4.6.4

coder/code-server

6 of 57 projects failed to build with the old tsc

src/tsconfig.json

error TS2741: Property 'colorSpace' is missing in type '{ width: number; height: number; data: Uint8ClampedArray; }' but required in type 'ImageData'.
- src/vs/editor/test/browser/view/minimapCharRenderer.test.ts#L60

facebook/docusaurus

31 of 41 projects failed to build with the old tsc

packages/docusaurus-theme-classic/tsconfig.json

error TS2698: Spread types may only be created from object types.
- packages/docusaurus-theme-classic/src/theme/CodeBlock/Container/index.tsx#L26
- packages/docusaurus-theme-classic/src/theme/NavbarItem/index.tsx#L36

reduxjs/react-redux

test/typetests/tsconfig.json

error TS2698: Spread types may only be created from object types.
- src/components/connect.tsx#L730

tsconfig.json

error TS2698: Spread types may only be created from object types.
- src/components/connect.tsx#L730

react-bootstrap/react-bootstrap

test/tsconfig.json

error TS2774: This condition will always return true since this function is always defined. Did you mean to call it instead?
- src/ToggleButtonGroup.tsx#L102

tsconfig.json

error TS2774: This condition will always return true since this function is always defined. Did you mean to call it instead?
- src/ToggleButtonGroup.tsx#L102

statelyai/xstate

6 of 20 projects failed to build with the old tsc

packages/xstate-inspect/tsconfig.json

error TS2731: Implicit conversion of a 'symbol' to a 'string' will fail at runtime. Consider wrapping this expression in 'String(...)'.
- packages/core/src/StateNode.ts#L1601 in packages/core/tsconfig.json

packages/xstate-test/tsconfig.json

error TS2731: Implicit conversion of a 'symbol' to a 'string' will fail at runtime. Consider wrapping this expression in 'String(...)'.
- packages/core/src/StateNode.ts#L1601 in packages/core/tsconfig.json

palantir/blueprint

3 of 25 projects failed to build with the old tsc

packages/docs-theme/src/tsconfig.json

error TS2731: Implicit conversion of a 'symbol' to a 'string' will fail at runtime. Consider wrapping this expression in 'String(...)'.
- packages/docs-theme/src/common/context.ts#L103

lensapp/lens

6 of 9 projects failed to build with the old tsc

tsconfig.extension-api.json

error TS2345: Argument of type 'import("/mnt/ts_downloads/lens/node_modules/abort-controller/dist/abort-controller").AbortSignal' is not assignable to parameter of type 'AbortSignal'.
- src/common/k8s-api/kube-object.store.ts#L430
error TS2698: Spread types may only be created from object types.

tsconfig.json

error TS2345: Argument of type 'import("/mnt/ts_downloads/lens/node_modules/abort-controller/dist/abort-controller").AbortSignal' is not assignable to parameter of type 'AbortSignal'.
- src/common/k8s-api/kube-object.store.ts#L430
error TS2322: Type 'AbortSignal' is not assignable to type 'import("/mnt/ts_downloads/lens/node_modules/@types/node-fetch/externals").AbortSignal'.
- src/renderer/components/+helm-charts/helm-chart-details.tsx#L103
error TS2698: Spread types may only be created from object types.

webpack/tsconfig.json

error TS2345: Argument of type 'import("/mnt/ts_downloads/lens/node_modules/abort-controller/dist/abort-controller").AbortSignal' is not assignable to parameter of type 'AbortSignal'.
- src/common/k8s-api/kube-object.store.ts#L430
error TS2322: Type 'AbortSignal' is not assignable to type 'import("/mnt/ts_downloads/lens/node_modules/@types/node-fetch/externals").AbortSignal'.
- src/renderer/components/+helm-charts/helm-chart-details.tsx#L103
error TS2698: Spread types may only be created from object types.

facebook/docusaurus

https://github.com/facebook/docusaurus/blob/c16a08cba59bea5e48d3a79cee82c23aaae29876/packages/docusaurus-theme-classic/src/theme/CodeBlock/Container/index.tsx#L26

I'd like to know if there's a better way to do this, without using as any. I've expressed the same concern in #48556 (comment)

I would probably switch to as {}. Unlike unioning a never with other types (where you are enriching the absence of execution with possible executions), spreading a never sort of implies that you should get never out of it.

Sigh What if I told you that {} is banned by TypeScript-ESLint as well😄 But thanks for that tip, it makes sense. I'll negotiate with my linter.

Wh-really? Why? Because it insists on using object?

Yeah, the reason is because {} doesn't do excess property checks and even accepts primitives, so people using it to represent "empty object" would often shoot themselves in the foot. See @typescript-eslint/ban-types

Also, {} doesn't work, because in fact, the compiler only accepts props that's assignable to props of both div and pre, which seems to reduce to never. We'll use as any for now, but I hope there's a better pattern to do this, possibly with oneof generics.

Opened react-bootstrap/react-bootstrap#6345

I would use as object instead of as any

Ref typescript-eslint/typescript-eslint#5018 (comment)

But as object doesn't fix that particular error😢 I have yet to know a fix

The interesting thing is even not passing any props won't work. I think it's already intersecting to never in the generic body.

Hi, I also encountered a similar error after upgrading my TypeScript. I am using AbortController from abort-controller, and here is my code:

import AbortController from "abort-controller";
const controller = new AbortController();
const init: RequestInit = {
    headers: headers,
    signal: controller.signal,
};

TypeScript raises an error saying:

error TS2322: Type 'import("/.../node_modules/abort-controller/dist/abort-controller").AbortSignal' is not assignable to type 'AbortSignal'.

200         signal: controller.signal,
            ~~~~~~

I am wondering is there a proper way to solve this error. Thanks!

You may want to file a bug on abort-controller or add the following to your package.json and npm install.

{
 "devDependencies": {
    "@typescript/lib-dom": "npm:@types/web"
  }
}

Navigation Menu

Repository navigation

[NewErrors] 4.7.1-rc vs 4.6.4 #49142

coder/code-server

src/tsconfig.json

facebook/docusaurus

packages/docusaurus-theme-classic/tsconfig.json

reduxjs/react-redux

test/typetests/tsconfig.json

tsconfig.json

react-bootstrap/react-bootstrap

test/tsconfig.json

tsconfig.json

statelyai/xstate

packages/xstate-inspect/tsconfig.json

packages/xstate-test/tsconfig.json

palantir/blueprint

packages/docs-theme/src/tsconfig.json

lensapp/lens

tsconfig.extension-api.json

tsconfig.json

webpack/tsconfig.json

facebook/docusaurus

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[NewErrors] 4.7.1-rc vs 4.6.4 #49142

Description

Activity

Josh-Cena commented on May 17, 2022

DanielRosenwasser commented on May 17, 2022

Josh-Cena commented on May 18, 2022

DanielRosenwasser commented on May 18, 2022

Josh-Cena commented on May 18, 2022

Josh-Cena commented on May 18, 2022

RyanCavanaugh commented on May 19, 2022

RyanCavanaugh commented on May 20, 2022

Josh-Cena commented on May 20, 2022

UNIDY2002 commented on May 25, 2022

DanielRosenwasser commented on May 25, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions