Paste into editor with format on paste removes pasted word

Matt Bierner (@mjbvz)

TS Template added by Matt Bierner (@mjbvz)

TypeScript Version: @4.7.0-dev.20220222

Search Terms

Format on paste
format

I have auto save enabled and format on paste. When I paste a string into a another string, that string is removed. See

//cc Sandeep Somavarapu (@sandy081)

I cannot reproduce this on windows. Up for a quick meeting?

Yes

Henning figured out that this is a bug in the typescript formatter and it reproduces as simple as with this:

const x = f('aaaa', 'aaaa').x()

When you try to paste the aaaa into the second location.

Here's the format request I see pasting into the first argument in the above example:

[Trace  - 00:27:06.888] <syntax> Sending request: format (5). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/san/index.ts",
    "line": 1,
    "offset": 14,
    "endLine": 1,
    "endOffset": 18
}
[Trace  - 00:27:06.919] <syntax> Response received: format (5). Request took 32 ms. Success: true 
Result: [
    {
        "start": {
            "line": 1,
            "offset": 13
        },
        "end": {
            "line": 1,
            "offset": 23
        },
        "newText": ""
    }
]

So far, it looks like the tree walking part of the formatter doesn't correctly increment the scanner, so the end-of-tree section of the code ends up formatting ( ) instead of ( "bar".

Now I have to go understand how the tree walk works.

Broken in #46875, which is not surprising since that PR adds the end-of-tree section.

Edit: The tree walk was probably already incorrect, it's just the new end-of-tree code relies on it being correct.

Fix formatter's processChildNodes

Fix formatter's processChildNodes (#48921)

I also have this issue on mac

Navigation Menu

Repository navigation

Paste into editor with format on paste removes pasted word #48006

6 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Paste into editor with format on paste removes pasted word #48006

Description

Activity

hediet commented on Feb 21, 2022

bpasero commented on Feb 21, 2022

bpasero commented on Feb 21, 2022

mjbvz commented on Feb 23, 2022

6 remaining items

sandersn commented on Apr 29, 2022

sandersn commented on Apr 29, 2022

DarinDev1000 commented on Jul 11, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions