Skip to content

Method signature completion doesn't respect the custom indent size #47044

Closed as not planned

Description

@Tyriar

Using Spaces: 2, there are 6 spaces in the gif below when there should only be 4
recording (5)

Activity

  1. changed the title [-]TypeScript fill in abstract implementation doesn't respect the indent style[/-] [+]Method signature completion doesn't respect the custom indent size[/+] on Dec 6, 2021
  2. mjbvz commented on Dec 6, 2021

    @mjbvz
    Contributor

    Minimal repo:

    class Base {
      foo() { }
    }
    
    class Sub extends Base {
      
    }
    1. Change indentation to 2 spaces
    2. Complete foo inside of sub

    Bug
    The body is still indented by four spaces

  3. removed their assignment
    on Dec 6, 2021
  4. RyanCavanaugh commented on Dec 7, 2021

    @RyanCavanaugh
    Member

    Gabriela Araujo Britto (@gabritto) FYI in case you want to reschedule sooner

  5. gabritto commented on Dec 7, 2021

    @gabritto
    Member

    might be solved by #46832 since that PR makes it so we call the formatter for the completion text, but I'm going to check.

  6. locked as resolved and limited conversation to collaborators on Dec 3, 2025
  7. RyanCavanaugh commented on Dec 3, 2025

    @RyanCavanaugh
    Member

    Closing language service bugs related to the 6.0 implementation. For more information, see #62827

  8. mjbvz commented on Dec 8, 2025

    @mjbvz
    Contributor

    Looks like method snippet completions haven't been ported over yet: microsoft/typescript-go#2279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions