Skip to content

Offer quick fix for some uses of 'await' outside an async context #46986

Closed
#46994
Closed
Offer quick fix for some uses of 'await' outside an async context#46986
#46994
Labels
Domain: Error MessagesThe issue relates to error messagingDomain: LS: Quick FixesEditor-provided fixes, often called code actions.Experience EnhancementNoncontroversial enhancementsGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this
Milestone
TypeScript 4.6.0

Description

@rbuckton
Ron Buckton (rbuckton)
opened on Dec 1, 2021

Originally discussed in #38483.

We currently offer a quick fix to add an async modifier if we parse await in a non-async context when the await is unambiguously an AwaitExpression:

image

However, we do not offer that quick fix if we parse await in cases where it is ambiguous (such as in a call expression):

image

We should consider special-casing the error message for await when it is ambiguous so that we can offer compatible quick fixes.

Activity

  1. a-tarasyuk commented on Dec 2, 2021

    @a-tarasyuk
    Oleksandr Tarasiuk (a-tarasyuk)
    on Dec 2, 2021
    Contributor

    Daniel Rosenwasser (@DanielRosenwasser) Ron Buckton (@rbuckton) Should it be done in suggestionDiagnostics?

  2. DanielRosenwasser commented on Dec 2, 2021

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Dec 2, 2021
    Member

    I think the idea is that instead of Cannot find name 'await'. we would possibly issue a special-cased diagnostic like

    Cannot find name 'await'. Did you mean to write this in an async function?

    and provide a quick fix for that.

  3. a-tarasyuk commented on Dec 2, 2021

    @a-tarasyuk
    Oleksandr Tarasiuk (a-tarasyuk)
    on Dec 2, 2021
    Contributor

    Daniel Rosenwasser (@DanielRosenwasser) Ok, thanks

  4. Daniel Rosenwasser (DanielRosenwasser)
    added
    Domain: Error MessagesThe issue relates to error messaging
    Domain: LS: Quick FixesEditor-provided fixes, often called code actions.
    Experience EnhancementNoncontroversial enhancements
    Good First IssueWell scoped, documented and has the green light
    Help WantedYou can do this
    on Dec 2, 2021
  5. Daniel Rosenwasser (DanielRosenwasser)
    added this to the TypeScript 4.6.0 milestone on Dec 2, 2021
  6. Daniel Rosenwasser (DanielRosenwasser)
    closed this as completedin #46994on Dec 3, 2021

  7. DanielRosenwasser commented on Dec 3, 2021

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Dec 3, 2021
    Member

    Thanks Oleksandr Tarasiuk (@a-tarasyuk)!

  8. a-tarasyuk commented on Dec 3, 2021

    @a-tarasyuk
    Oleksandr Tarasiuk (a-tarasyuk)
    on Dec 3, 2021
    Contributor

    Daniel Rosenwasser (@DanielRosenwasser) Not at all :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: Error MessagesThe issue relates to error messagingDomain: LS: Quick FixesEditor-provided fixes, often called code actions.Experience EnhancementNoncontroversial enhancementsGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions