Invalid property access in quick info relating to type arguments #4616

Activity

1. Daniel Rosenwasser (DanielRosenwasser)

   added

   BugA bug in TypeScriptA bug in TypeScript

   on Sep 3, 2015
2. weswigham commented on Sep 5, 2015

   

   Wesley Wigham (weswigham)

   on Sep 5, 2015

   Member

   More actions

   This happens with the following SyntaxKinds in the definition:

   SyntaxKind.ConstructorType,
   SyntaxKind.ConstructSignature,
   SyntaxKind.IndexSignature,
   SyntaxKind.CallSignature,
   SyntaxKind.MethodSignature

   Since all of those are 'isFunctionLike`, and are returned by getContainingFunction but are not the node on which that type parameter lies. (I believe)

   Here's a comprehensive set of tests exposing the issues:

   ///<reference path="fourslash.ts" />
   
   //// type Ctor<AA> = new () => A/*1*/A;
   //// type MixinCtor<AA> = new () => AA & { constructor: MixinCtor<A/*2*/A> };
   //// type NestedCtor<AA> = new() => AA & (new () => AA & { constructor: NestedCtor<A/*3*/A> });
   //// type Method<AA> = { method(): A/*4*/A };
   //// type Construct<AA> = { new(): A/*5*/A };
   //// type Call<AA> = { (): A/*6*/A };
   //// type Index<AA> = {[foo: string]: A/*7*/A};
   //// type GenericMethod<AA> = { method<BB>(): A/*8*/A & B/*9*/B }
   
   goTo.marker('1');
   verify.quickInfoIs('(type parameter) AA in type Ctor<AA>');
   goTo.marker('2');
   verify.quickInfoIs('(type parameter) AA in type MixinCtor<AA>');
   goTo.marker('3');
   verify.quickInfoIs('(type parameter) AA in type NestedCtor<AA>');
   goTo.marker('4');
   verify.quickInfoIs('(type parameter) AA in type Method<AA>');
   goTo.marker('5');
   verify.quickInfoIs('(type parameter) AA in type Construct<AA>');
   goTo.marker('6');
   verify.quickInfoIs('(type parameter) AA in type Call<AA>');
   goTo.marker('7');
   verify.quickInfoIs('(type parameter) AA in type Index<AA>');
   goTo.marker('8');
   verify.quickInfoIs('(type parameter) AA in type GenericMethod<AA>');
   goTo.marker('9');
   verify.quickInfoIs('(type parameter) BB in method<BB>(): AA & BB');

   The issue is on ~line 4228 of services.ts. We call getContainingFunction(location) when what we really want is something else. What we want to know if the type parameter is derived from its enclosing function or its enclosing type alias, and the presence of a containing function-like node is not enough information to determine that.
3. weswigham commented on Sep 5, 2015

   

   Wesley Wigham (weswigham)

   on Sep 5, 2015

   Member

   More actions

   I also advise checking against the quick infos for this, in additon to those in the test above:

   type Nesting<T> = {method<U>(): new <W>() => T & U & W};

   On 4a85546 this errors on T (as above), U is correct, and claims W is on an anonymous function rather than a ctor (missing the new keyword). (Which is possibly a formatting bug for that kind of ctor type signature, but could be indicative of something else)
4. Mohamed Hegazy (mhegazy)

   added this to the TypeScript 1.8 milestone on Sep 18, 2015
5. Mohamed Hegazy (mhegazy)

   assigned

   Yui (yuit)

   on Sep 18, 2015
6. Mohamed Hegazy (mhegazy)

   modified the milestones: TypeScript 1.7, TypeScript 1.8 on Oct 9, 2015
7. Yui (yuit)

   closed this as completedin #5899on Dec 2, 2015
8. Yui (yuit)

   added

   FixedA PR has been merged for this issueA PR has been merged for this issue

   on Dec 2, 2015
9. microsoft

   locked and limited conversation to collaborators on Jun 19, 2018
10. TypeScript Bot (typescript-bot)

    unassigned

    Yui (yuit)

    on Jun 19, 2018