Activity

1. Andrew Branch (andrewbranch)

   added

   BugA bug in TypeScriptA bug in TypeScript

   CrashFor flagging bugs which are compiler or service crashes or unclean exits, rather than bad outputFor flagging bugs which are compiler or service crashes or unclean exits, rather than bad output

   on Sep 23, 2021
2. Andrew Branch (andrewbranch)

   added this to the TypeScript 4.5.1 milestone on Sep 23, 2021
3. Andrew Branch (andrewbranch)

   assigned

   Nathan Shively-Sanders (sandersn)

   on Sep 23, 2021
4. sandersn commented on Oct 4, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 4, 2021

   Member

   More actions

   Broken by #43183
5. sandersn commented on Oct 4, 2021

   

   Nathan Shively-Sanders (sandersn)

   on Oct 4, 2021

   Last edited by sandersn

   Member

   More actions

   #43183 skips nodes whose parents are JSX elements, but that doesn't apply to JSXExpression's expressions. I don't know if it should.

   Edit: Exempting the expression of a JSXExpression makes the below test pass.
   (by adding !(isJsxExpression(node.parent) && node.parent.expression === node) && to hasNonBindingPatternContextualTypeWithNoGenericTypes)

   Here's the test case from the playground link:

   interface IData<MenuItemVariant extends ListItemVariant = ListItemVariant.OneLine> {
       menuItemsVariant?: MenuItemVariant;
   }
   
   function Menu<MenuItemVariant extends ListItemVariant = ListItemVariant.OneLine>(
       data: IData<MenuItemVariant>
   ) {
       const listItemVariant = data.menuItemsVariant ?? ListItemVariant.OneLine;
   
       // Non-tsx version compiles to js/jsx as expected
       //return ListItem({variant: listItemVariant});
   
       // tsx version doesn't compile and throws error as can be seen in devtools/console
       return <ListItem variant={listItemVariant} />;
   }
   
   type IListItemData = { variant: ListItemVariant.Avatar; } | { variant: ListItemVariant.OneLine; };
   
   enum ListItemVariant {
       OneLine,
       Avatar,
   }
   
   function ListItem(_data: IListItemData) {
       return null; 
   }
6. Nathan Shively-Sanders (sandersn)

   assigned

   Anders Hejlsberg (ahejlsberg)

   and unassigned

   Nathan Shively-Sanders (sandersn)

   on Oct 4, 2021
7. TypeScript Bot (typescript-bot)

   added

   Fix AvailableA PR has been opened for this issueA PR has been opened for this issue

   on Oct 14, 2021
8. Anders Hejlsberg (ahejlsberg)

   closed this as completedin #46354on Oct 14, 2021
9. microsoft

   locked as resolved and limited conversation to collaborators on Oct 21, 2025