Skip to content

Convert unit tests in 'convertCompilerOptionsFromJson' to use baselines #44950

Closed
Closed
Convert unit tests in 'convertCompilerOptionsFromJson' to use baselines#44950
Labels
InfrastructureIssue relates to TypeScript team infrastructure

Description

@rbuckton
Ron Buckton (rbuckton)
opened on Jul 8, 2021

Some of the unit tests in convertCompilerOptionsFromJson.ts have long lines that are difficult to edit as the message text increases in size:

TypeScript/src/testRunner/unittests/config/convertCompilerOptionsFromJson.ts

Line 298 in 2a01f92

messageText: "Argument for '--lib' option must be: 'es5', 'es6', 'es2015', 'es7', 'es2016', 'es2017', 'es2018', 'esnext', 'dom', 'dom.iterable', 'webworker', 'webworker.importscripts', 'scripthost', 'es2015.core', 'es2015.collection', 'es2015.generator', 'es2015.iterable', 'es2015.promise', 'es2015.proxy', 'es2015.reflect', 'es2015.symbol', 'es2015.symbol.wellknown', 'es2016.array.include', 'es2017.object', 'es2017.sharedmemory', 'es2017.string', 'es2017.intl', 'es2017.typedarrays', 'es2018.asynciterable', 'es2018.intl', 'es2018.promise', 'es2018.regexp', 'esnext.array', 'esnext.symbol', 'esnext.intl', 'esnext.bigint', 'esnext.bigint', 'esnext.string', 'esnext.promise'.",

We should consider changing these tests to use baselines/snapshots instead of inline code.

Activity

  1. Ryan Cavanaugh (RyanCavanaugh)
    added
    InfrastructureIssue relates to TypeScript team infrastructure
    on Jul 12, 2021

  2. jakebailey commented on Jul 7, 2023

    @jakebailey
    Jake Bailey (jakebailey)
    on Jul 7, 2023
    Member

    This was done in #53324.

  3. Jake Bailey (jakebailey)
    closed this as completedon Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    InfrastructureIssue relates to TypeScript team infrastructure

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions