Repository navigation
Make PaymentRequest .show method param optional #44560
Description
Bug Report
#44423 added types for the promise param on the .show() method on PaymentRequest. The spec states that this parameter is optional
🔎 Search Terms
show method PaymentRequest
🕗 Version & Regression Information
not present in 4.2.3, present in 4.3.2
⏯ Playground Link
Playground link with relevant code
💻 Code
the type definition just needs to be tweaked slightly
// current
show(detailsPromise: PaymentDetailsUpdate | Promise<PaymentDetailsUpdate>): Promise<PaymentResponse>;
// should be
show(detailsPromise?: PaymentDetailsUpdate | Promise<PaymentDetailsUpdate>): Promise<PaymentResponse>;🙁 Actual behavior
await request.show(); // error: An argument for 'detailsPromise' was not provided🙂 Expected behavior
await request.show(); // no error
Activity
mayeedwin commentedon Jul 3, 2021
Getting the same error. Looked at TypeScript-DOM-lib-generator and seems like the bug is fixed. Maybe not published yet. But for now, you can manually edit on your dev environment to keep going as you await for the release.
cc Yaksh Bariya (@thunder-coding)
jakebailey commentedon Jul 9, 2023
This was fixed back in #44684.