Repository navigation
Use explicit extensions in TypeScript's package.json for Node ES resolution compatibility #44342
Description
Bug Report
🕗 Version & Regression Information
Versions:
- 4.3.2
- 4.1.2
- This is a crash
- This is the behavior in every version I tried
⏯ Playground Link
💻 Code
Run tsc (yarn tsc, yarn exec tsc, npx tsc, ./node_modules/.bin/tsc) with nodejs flag --experimental-specifier-resolution=node (NODE_OPTIONS="--experimental-specifier-resolution=node" tsc)
🙁 Actual behavior
internal/process/esm_loader.js:74
internalBinding('errors').triggerUncaughtException(
^
TypeError [ERR_INVALID_MODULE_SPECIFIER]: Invalid module "file:///path/to/project/node_modules/typescript/bin/tsc"
at Loader.getFormat (internal/modules/esm/loader.js:117:13)
at async Loader.getModuleJob (internal/modules/esm/loader.js:242:20)
at async Loader.import (internal/modules/esm/loader.js:176:17)
at async Object.loadESM (internal/process/esm_loader.js:68:5) {
code: 'ERR_INVALID_MODULE_SPECIFIER'
}
🙂 Expected behavior
Build without errors
Activity
dansaper commentedon May 31, 2021
I assume this is related to https://gist.github.com/weswigham/22a064ffa961d5921077132ae2f8da78?
tsapko3628 commentedon May 31, 2021
Not, it's not.
This problem because of bin script definition.
Bin scripts defined as
{ "tsc": "./bin/tsc.js", "tsserver": "./bin/tsserver" }And when I call
yarn tsc, nodejs trying to runnode_modules/typescript/bin/tsc. This file hasn't extension and nodejs throws an error.Why it works in Jest?
Because it use another
bindeclaration like this:{ "jest": "./bin/jest.js" }For package manager, this script has link with name jest, but nodejs run jest.js, file with extension.
So, solving my problem is adding
.jsin bin files and in paths inpackage.jsonbin. It won't change behavior for exists project by help projects with configurations like mine.As you can see, another experimental flags for native modules aren't change behavior (Now I run tsc without
--experimental-specifier-resolution, but with all another flags in scripts and it works)tsapko3628 commentedon Jun 1, 2021
I created pull request with resolution. Can somebody approve it?
[-]Support node es modules resolution[/-][+]Use explicit extensions in TypeScript's package.json for Node ES resolution compatibility[/+]