You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
HTMLElement.setAttribute's parameters are marked optional; they are not #4407
lib.d.ts defines HTML.setAttribute with a signature of (name?: string, value?: string). Neither of the parameters are actually optional and will cause runtime errors on at least Chrome and Firefox.
changed the title [-]HTMLElement.setAttribute's parameters are marked optional; it is not[/-][+]HTMLElement.setAttribute's parameters are marked optional; they are not[/+]on Aug 21, 2015
Activity
[-]HTMLElement.setAttribute's parameters are marked optional; it is not[/-][+]HTMLElement.setAttribute's parameters are marked optional; they are not[/+]mhegazy commentedon Dec 8, 2015
PRs are welcomed. here is some documentation for adding new types to lib.d.ts: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes
LPGhatguy commentedon Dec 9, 2015
I've submitted a PR (as noted just above this) to the TSJS-lib-generator project.