Repository navigation
Difference in behavior with encodedSemanticClassifications-full in TS 4.1 compared to using VS Code plugin #41262
Description
TypeScript Version: 4.1.0-dev.20201026
Repro
-
Using TS
4.1.0-dev.20201026and a build of VS Code that explicitly disables thetypescript-vscode-sh-pluginpluginHere's the change in the VS Code repo that disables the plugin:
diff --git a/extensions/typescript-language-features/package.json b/extensions/typescript-language-features/package.json index dfd3f6295a..aa3763aaf7 100644 --- a/extensions/typescript-language-features/package.json +++ b/extensions/typescript-language-features/package.json @@ -1114,12 +1114,6 @@ } ] } - ], - "typescriptServerPlugins": [ - { - "name": "typescript-vscode-sh-plugin", - "enableForWorkspaceTypeScriptVersions": true - } ] } }
-
Use the TS File:
class Foo {} const a = Foo; console.log(a);
-
Look at semantic highlighting
Bug
With TS 4.1 and the plugin disabled, I see this response:
[Trace - 00:50:46.802] <semantic> Response received: encodedSemanticClassifications-full (17). Request took 1673 ms. Success: true
Result: {
"spans": [
6,
3,
11,
24,
3,
11
],
"endOfLineState": 0
}
With the plugin enabled, I see:
[Trace - 00:50:59.813] <semantic> Response received: encodedSemanticClassifications-full (16). Request took 980 ms. Success: true
Result: {
"spans": [
6,
3,
257,
20,
1,
257,
24,
3,
256,
30,
7,
2064,
38,
3,
3088,
42,
1,
256
],
"endOfLineState": 0
}
As you can see, the plugin seems to be providing a lot more information
Orta Therox (@orta) Is there any work we need to do on the VS Code side to adopt the new semantic work in TS 4.1?
Activity
orta commentedon Nov 4, 2020
Ah yeah, I made it default to the old behavior so that VS wasn't forced to make changes!
The API for
getSemanticClassificationsin the language service now has an optional third param which is a 'format':Which you can put "2020":
To trigger the new formatter, I expect that's just an extra param somewhere on the vscode side?
mjbvz commentedon Nov 20, 2020
Thanks Orta Therox (@orta). I gave this a try but can't get it working. The problems I ran into:
I'm not sure how I can pass the
formatparameter to the server. I tried adding it to the request but that doesn't seem to workI don't see the new semantic request types in the server's
protocol.d.tsorta commentedon Nov 24, 2020
I've sent a PR updating the 4.0 branch with the param, will just d the same thing for the master branch now
mjbvz commentedon Dec 2, 2020
Thanks Orta Therox (@orta). Just tested this on
4.2.0-dev.20201201and still seeing issues (although I'm not 100% that the changes have been picked up):SemanticDiagnosticsSyncRequestArgsDoes not include aformatargument in the protocol typingsSemanticDiagnosticsSyncRequestArgsdoes not seem to take a range for the file. InencodedSemanticClassifications-full, we currently do pass a rangeEven if I try force add
format: '2020'to the request, I still don't see the more complete results returnedorta commentedon Dec 2, 2020
Do you have a WIP vscode branch? I can try get that up and running and work out the kinks?
mjbvz commentedon Dec 5, 2020
Orta Therox (@orta) Here's a branch with the changes: https://github.com/microsoft/vscode/tree/dev/mjbvz/semantic-ts. And the relevant change
I actually was using the wrong types in my earlier comments.
SemanticDiagnosticsis not what we want. Instead it looks likeSemanticClassificationstypes are missing from the protocol