window.removeEventListener needs specialized signatures like addEventListener #3871

Activity

1. danquirk commented on Jul 15, 2015

   

   Dan Quirk (danquirk)

   on Jul 15, 2015

   Member

   More actions

   Which version of lib.d.ts are you looking at? They appear the same in the latest bits

   interface EventTarget {
       addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
       dispatchEvent(evt: Event): boolean;
       removeEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
   }
   
   declare function addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
   declare function dispatchEvent(evt: Event): boolean;
   declare function removeEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
2. Dan Quirk (danquirk)

   closed this as completedon Jul 15, 2015
3. carlpaten commented on Jul 15, 2015

   

   Carl Patenaude-Poulin (carlpaten)

   on Jul 15, 2015

   Author

   More actions

   Version isn't clear, but there's this bit:

   addEventListener(type: "MSGestureChange", listener: (ev: MSGestureEvent) => any, useCapture?: boolean): void;
   addEventListener(type: "MSGestureDoubleTap", listener: (ev: MSGestureEvent) => any, useCapture?: boolean): void;
   addEventListener(type: "MSGestureEnd", listener: (ev: MSGestureEvent) => any, useCapture?: boolean): void;
   ...
   addEventListener(type: "waiting", listener: (ev: Event) => any, useCapture?: boolean): void;
   addEventListener(type: "wheel", listener: (ev: WheelEvent) => any, useCapture?: boolean): void;
   addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
   
4. danquirk commented on Jul 15, 2015

   

   Dan Quirk (danquirk)

   on Jul 15, 2015

   Member

   More actions

   Ah, I see, you mean you want all those specialized signatures for removeEventListener.
5. Dan Quirk (danquirk)

   reopened this on Jul 15, 2015
6. Dan Quirk (danquirk)

   changed the title [-]window.removeEventListener needs a more accurate type definition[/-] [+]window.removeEventListener needs specialized signatures like addEventListener[/+] on Jul 15, 2015
7. Dan Quirk (danquirk)

   added

   SuggestionAn idea for TypeScriptAn idea for TypeScript

   In DiscussionNot yet reached consensusNot yet reached consensus

   Domain: lib.d.tsThe issue relates to the different libraries shipped with TypeScriptThe issue relates to the different libraries shipped with TypeScript

   on Jul 15, 2015
8. mhegazy commented on Jul 16, 2015

   

   Mohamed Hegazy (mhegazy)

   on Jul 16, 2015

   Contributor

   More actions

   The reason addEventListener has these overloads is to allow for flowing contextual type to the event handler. but in the remove case, why would pass a lambda? LilRed can you share a sample where this is useful in removeEventListener
9. carlpaten commented on Jul 18, 2015

   

   Carl Patenaude-Poulin (carlpaten)

   on Jul 18, 2015

   Author

   More actions

   You call removeEventListener with a reference to the lambda you called
   addEventListener with.

   function foo(bar: StorageEvent) { console.log("foo!") };
   window.addEventListener("storage", foo); //event handler is registered
   window.removeEventListener("storage", foo); //back to normal
   
10. mhegazy commented on Jul 20, 2015

    

    Mohamed Hegazy (mhegazy)

    on Jul 20, 2015

    Contributor

    More actions

    :) i understand. i was talking about the contextual type. contextual types are what allows you to get type of a lambda paramter e.g.:

    window.addEventListener("storage", (e) => {
        e; // <- e is StorageEvent becuase contextual type flowed from the definition of window.addEventListener("storage", ...);
    })

    so it seems the scenario you are talking about is:

    function foo(bar: StorageEvent) { console.log("foo!") };
    
    window.removeEventListener("click", foo); // Error MouseEventListener is not assignable to StorageEventListener

    is this correct? if so there is a different problem that would make this not work, once #1003 is fixed we can revisit this.
11. Mohamed Hegazy (mhegazy)

    added

    DeclinedThe issue was declined as something which matches the TypeScript visionThe issue was declined as something which matches the TypeScript vision

    on Feb 22, 2016
12. mhegazy commented on Feb 22, 2016

    

    Mohamed Hegazy (mhegazy)

    on Feb 22, 2016

    Contributor

    More actions

    as mentioned earlier in my reply, this does not seem to be of much value as the event is usually defined in the addEventListener method. please reopen if this is not the case.
13. Mohamed Hegazy (mhegazy)

    closed this as completedon Feb 22, 2016
14. MaxDaten commented on Nov 8, 2016

    

    Jan-Philip Loos (MaxDaten)

    on Nov 8, 2016

    More actions

    Hi,

    I'm using typescript with ionic 1.0 & cordova and bumping against this error:

    TypeScript error: typings/globals/InAppBrowser/index.d.ts(46,11): Error TS2430: Interface 'InAppBrowser' incorrectly extends interface 'Window'.
      Types of property 'addEventListener' are incompatible.
        Type '{ (type: "loadstart", callback: (event: InAppBrowserEvent) => void): void; (type: "loadstop", cal...' is not assignable to type '{ (type: "MSGestureChange", listener: (this: this, ev: MSGestureEvent) => any, useCapture?: boole...'.
          Types of parameters 'type' and 'type' are incompatible.
            Type '"MSGestureChange"' is not assignable to type '"loadstart"'.
    

    with:

    $ tsc --version
    Version 2.0.6
    

    What is the problem here and how to solve it? Thanks for any advice.
15. mhegazy commented on Nov 8, 2016

    

    Mohamed Hegazy (mhegazy)

    on Nov 8, 2016

    Contributor

    More actions

    looks like InAppBrowser does not include all overloads for addEventListener which makes the class/interface not implement the Window interface correctly. the fix would be done on the declaration file i would say.

    //cc Michael Braude (@mbraude)

    👍React with 👍1Reacted by Carl Patenaude-Poulin
16. microsoft

    locked and limited conversation to collaborators on Jun 19, 2018