Repository navigation
Wrong typing for document.open #33898
Description
TypeScript Version: 3.6.3
document.open (lib.d.ts) typing is wrong:
open(url?: string, name?: string, features?: string, replace?: boolean): Document;correct is:
open(url: string, name: string, features: string): Window | null;
open(type?: string, replace?: string): Document;https://developer.mozilla.org/en-US/docs/Web/API/Document/open
Related Issues:
#25495
Activity
RyanCavanaugh commentedon Oct 9, 2019
See #31246
sirian commentedon Oct 9, 2019
Ryan Cavanaugh (@RyanCavanaugh) it's about document.open, not window.open
RyanCavanaugh commentedon Oct 9, 2019
http://help.dottoro.com/ljvkwlod.php
I have no idea how all the different browsers behave here but don't really see the point in breaking people using the 4-argument variant for the sake of getting better argument names as proposed here (or maybe I'm missing something). Is there some case where you're getting an error that you shouldn't be?
sirian commentedon Oct 10, 2019
Ryan Cavanaugh (@RyanCavanaugh) Problem with return type. When
document.opencalled with 3 (or more) arguments -return type should be
Window | null. But now it returnsDocumentUpd. So I'm not against 4th argument (even though neither whatwg nor mdn describes it). I'm talking about return types
RyanCavanaugh commentedon Oct 10, 2019
sirian my bad for missing the return type; thank you for clarifying!
jakebailey commentedon Jul 9, 2023
As of #44684,
Document'sopenis now: