Repository navigation
Inconsistent treatment of shorthand methods with generic Partial #32416
Description
TypeScript Version: 3.5.1
Search Terms: inconsistent shorthand methods
Code
function assignPartial<T>(target: T, partial: Partial<T>): T {
return Object.assign(target, partial)
}
let obj = {
foo(bar: string) {}
}
assignPartial(obj, {foo: (...args) => {}})
assignPartial(obj, {foo(...args) {}})Expected behavior:
Both calls to assignPartial are typechecked the same, with no any types or errors.
Actual behavior:
In the second call, args is given the type any[], causing noImplicitAny to fail.
Additional notes:
- If you change
Partial<T>to justT, the error goes away (playground link). - If you keep
Partialbut hardcode the type instead of using generics, the error also goes away (playground link).
Related Issues: #11062, but it's a different inconsistency (and has been fixed).
Activity
russelldavis commentedon Jul 16, 2019
#32230 is related, however the fix for that bug does not fix this one (this bug persists in the latest nightly build, 3.6.0-dev.20190716).
russelldavis commentedon Jul 26, 2019
Ryan Cavanaugh (@RyanCavanaugh) Anders Hejlsberg (@ahejlsberg) mind taking a quick look (at least to triage)? This is basically the same issue as #32230 (which was put in the 3.6 milestone and partially fixed, but this variant of the issue remains).