Repository navigation
Revert this-parameter filtering for methods #31349
Description
We believe #20616 may be the cause of some recent slowness in editor completions. We are considering reverting the feature to increase performance (admittedly at the expense of some editor UX).
Activity
DanielRosenwasser commentedon May 10, 2019
Removing the logic doesn't seem to do much from what we've seen. Completions are still ridiculously slow.
ahejlsberg commentedon May 12, 2019
See #31354 for the real fix.
ahejlsberg commentedon May 13, 2019
I'm reopening this issue. Turns out this-parameter filtering is also a contributor to the slowdown, it's just that the eager conditional type true/false branch resolution is the main offender. I have verified that removing the this-parameter filtering greatly speeds up completions with styled-components. We basically need both fixes.
DanielRosenwasser commentedon May 13, 2019
Understandable if we have to, but it would be unfortunate. Libraries like fp-ts v2 would be affected.
mattiamanzati commentedon May 13, 2019
Is it really worth it? Will some flag to turn this on be present? DX will suffer a lot :/