Skip to content

Perf issues with @material-ui/icons #30908

Closed
Closed
Perf issues with @material-ui/icons#30908
Assignees
amcasey
Labels
BugA bug in TypeScriptDomain: PerformanceReports of unusually slow behaviorNeeds InvestigationThis issue needs a team member to investigate its status.
Milestone
Backlog

Description

@amcasey
Andrew Casey (amcasey)
opened on Apr 12, 2019

Server synced to 4fee628

Repro: In VS, create a new TypeScript Node Console App. Add npm references to @material-ui/icons and @material-ui/core (a peer dependency). Add the following import at the top of app.ts:

import * as icons from "@material-ui/icons";

Looks like the first updateGraph takes ~10 seconds.

code.zip
vs.zip

The log files are huge, but only because each project listing has ~5300 files. The Code log is for opening the same folder with

Version: 1.34.0-insider (user setup)
Commit: d234937aedcbc265d2272ba5861125293239f9c7
Date: 2019-04-05T05:18:43.251Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

Activity

  1. Andrew Casey (amcasey)
    assigned
    Sheetal Nandi (sheetalkamat)
    on Apr 12, 2019
  2. Andrew Casey (amcasey)
    added
    Domain: PerformanceReports of unusually slow behavior
    on Apr 12, 2019

  3. sheetalkamat commented on Apr 15, 2019

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Apr 15, 2019
    Member

    Running tsc with --extendedDiagnostics --noEmit on this project shows we are taking 7+s for creating program. (Ignore check time since from tsserver checking is not done as part of updateGraphWorker)

    Files:            5509
Lines:           64552
Nodes:          216323
Identifiers:     59606
Symbols:        152254
Types:           76084
Memory used:   234582K
I/O Read time:   1.46s
Parse time:      1.13s
Program time:    7.22s
Bind time:       0.85s
Check time:     12.81s
Total time:     20.88s
  4. Ryan Cavanaugh (RyanCavanaugh)
    added
    BugA bug in TypeScript
    on Jul 29, 2019
  5. Ryan Cavanaugh (RyanCavanaugh)
    added this to the TypeScript 3.7.0 milestone on Jul 29, 2019

  6. sheetalkamat commented on Oct 10, 2019

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Oct 10, 2019
    Member

    This seems to have gotten better with 3.7

    Info 62   [13:25:41.644] Finishing updateGraphWorker: Project: c:/Users/shkamat/source/repos/NodejsConsoleApp4/NodejsConsoleApp4/tsconfig.json Version: 1 structureChanged: true Elapsed: 3826ms


Files:                         347
Lines:                       62617
Nodes:                      202552
Identifiers:                 61435
Symbols:                    170168
Types:                       44388
Memory used:               193264K
Assignability cache size:    95961
Identity cache size:            36
Subtype cache size:              0
I/O Read time:               0.17s
Parse time:                  0.65s
ResolveTypeReference time:   0.01s
ResolveModule time:          0.45s
Program time:                1.32s
Bind time:                   0.34s
Check time:                  6.38s
Total time:                  8.04s
  7. Ryan Cavanaugh (RyanCavanaugh)
    modified the milestones: TypeScript 3.7.0, TypeScript 3.7.1 on Oct 14, 2019
  8. Ryan Cavanaugh (RyanCavanaugh)
    assigned
    Andrew Casey (amcasey)
    and unassigned
    Sheetal Nandi (sheetalkamat)
    on Oct 29, 2019
  9. Ryan Cavanaugh (RyanCavanaugh)
    modified the milestones: TypeScript 3.7.1, TypeScript 3.8.0 on Oct 29, 2019

  10. amcasey commented on Oct 29, 2019

    @amcasey
    Andrew Casey (amcasey)
    on Oct 29, 2019
    MemberAuthor

    Sheetal Nandi (@sheetalkamat) How did the file count drop so much?

  11. amcasey commented on Oct 30, 2019

    @amcasey
    Andrew Casey (amcasey)
    on Oct 30, 2019
    MemberAuthor

    I don't recall whether the original repro compiled cleanly, but this time I had to add @types\react, @types\react-dom, and @types\jsdom.

  12. Ryan Cavanaugh (RyanCavanaugh)
    modified the milestones: TypeScript 3.8.0, TypeScript 3.8.1 on Jan 8, 2020

  13. amcasey commented on Jan 25, 2020

    @amcasey
    Andrew Casey (amcasey)
    on Jan 25, 2020
    MemberAuthor

    Updating the metadata to reflect the fact that, while I am currently investigating, this is not yet an expected milestone for an actual fix.

  14. Andrew Casey (amcasey)
    added
    Needs InvestigationThis issue needs a team member to investigate its status.
    on Jan 25, 2020
  15. Andrew Casey (amcasey)
    removed this from the TypeScript 3.8.1 milestone on Jan 25, 2020
  16. Ryan Cavanaugh (RyanCavanaugh)
    added this to the Backlog milestone on Sep 11, 2020

  17. amcasey commented on Nov 17, 2022

    @amcasey
    Andrew Casey (amcasey)
    on Nov 17, 2022
    MemberAuthor

    I think this is too stale to be useful.

  18. Andrew Casey (amcasey)
    closed this as completedon Nov 17, 2022
  19. microsoft
    locked as resolved and limited conversation to collaborators on Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptDomain: PerformanceReports of unusually slow behaviorNeeds InvestigationThis issue needs a team member to investigate its status.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions