Visual Studio - Format on Enter no longer removes extra whitespace #28781

Activity

1. minestarks commented on Dec 3, 2018

   

   Mine Starks (minestarks)

   on Dec 3, 2018

   Contributor

   More actions

   Nathan Shively-Sanders (@sandersn) This is blocking our tests and I believe it exists in 3.2 which will ship with VS. My understanding is it causes a visible formatting issue in VS. Would you prioritize it accordingly?
2. Nathan Shively-Sanders (sandersn)

   self-assigned this

   on Dec 3, 2018
3. sandersn commented on Dec 4, 2018

   

   Nathan Shively-Sanders (sandersn)

   on Dec 4, 2018

   Member

   More actions

   Here's a fourslash repro:

   /// <reference path="fourslash.ts" />
   ////function foo()
   ////{
   ////    var bar;
   ////    /*1*/
   ////}
   goTo.marker('1')
   edit.insertLine("");
   verify.currentFileContentIs(`function foo()
   {
       var bar;
   
   
   }`);

   The two whitespace-only lines should both have 0 spaces. After #27978 merged, the first one still has 4 spaces.
4. Wesley Wigham (weswigham)

   added

   BugA bug in TypeScriptA bug in TypeScript

   Visual StudioIntegration with Visual StudioIntegration with Visual Studio

   Domain: FormatterThe issue relates to the built-in formatterThe issue relates to the built-in formatter

   Domain: LS: TSServerIssues related to the TSServerIssues related to the TSServer

   on Dec 4, 2018
5. sandersn commented on Dec 4, 2018

   

   Nathan Shively-Sanders (sandersn)

   on Dec 4, 2018

   Member

   More actions

   Selectively reverting #27978 shows that the regression was introduced by the change in trimTrailingWhitespacesForRemainingRange.
6. Nathan Shively-Sanders (sandersn)

   closed this as completedin #28848on Dec 4, 2018
7. microsoft

   locked as resolved and limited conversation to collaborators on Oct 21, 2025