Repository navigation
Allow class/function rename to be triggered on declaration keywords and modifiers #28268
Description
Search Terms
- rename
Suggestion
Follow up on microsoft/vscode#58907
Allow renames to be triggered on keywords such as public, private, class, const, readonly, and function to rename the symbol itself
class Foo {
public bar() { }
}
function func() { }
const x = 1;Use the triggerSpan property on the renameResponse to actually trigger the rename on the symbol.
We currently return "You cannot rename this element." for these cases
Activity
DanielRosenwasser commentedon Jan 24, 2020
Word of caution to make sure that this doesn't interfere with document highlights. Today, if you're hovering on
we highlight all occurrences of the
publickeyword withinC.RyanCavanaugh commentedon Jan 24, 2020
Daniel Rosenwasser (@DanielRosenwasser) is that a bug or a feature? The current behavior re:
publicseems uselessDanielRosenwasser commentedon Jan 25, 2020
That's a feature - document highlights aims to make it easy to scan through relevant/related declarations and constructs (e.g. the
switch/case/breakkeywords and everyexport-ed declaration). I don't see this as any different.It's also more consistent with the rest of the editor's visual cues (e.g. the way that VS Code highlights all occurrences of a word in a plain text buffer works more similarly to how we highlight the
exportkeyword than find-all-references).rbuckton commentedon Jan 30, 2020
Daniel Rosenwasser (@DanielRosenwasser): We currently highlight occurrences of the class or function name when you put the cursor on
classorfunction. Should we change that to highlight occurrences of theclass/functionkeyword instead to align with that behavior? We currently don't highlight occurrences of keywords likeinterface,type,enum,module, ornamespacetoday either.