Skip to content

Missing semi-colon in the extendsHelper #27312

Closed

Description

The missing semi-colon after the declaration of the extendStatics variable/function (es2015.ts, line 4082) results in linting errors (JSHint). For projects that contain both TypeScript and JavaScript source files, this presents a problem in CI builds, as its not always feasible to bypass semi-colon terminator requirements when linting the project.

It looks like this is just an oversight, since semi-colons are used consistently elsewhere.

This would not show up as a build error since the helper is specified as a string of text.

Expected behavior:
The extendsHelper helper should include a semi-colon after declaring the extendsStatic variable.

Actual behavior:
The semi-colon is missing.

Activity

  1. spratmannc commented on Sep 24, 2018

    @spratmannc
    ContributorAuthor

    #27313 Should address this.

  2. PaulIvanov commented on Oct 2, 2018

    @PaulIvanov

    does this issue need to be closed?

  3. spratmannc commented on Oct 2, 2018

    @spratmannc
    ContributorAuthor

    No. I'm still waiting on pull request #27313 to be reviewed. Do I need to do something special to get it looked at?

  4. spratmannc commented on Oct 2, 2018

    @spratmannc
    ContributorAuthor

    PR was completed. Closing issue.

  5. locked as resolved and limited conversation to collaborators on Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions