Repository navigation
Error when accessing private property in object destructuring assignment with computed name #26572
Description
TypeScript Version: 3.1.0-dev.20180818
Search Terms:
Code
class Foo {
private prop = 1;
}
let prop: any;
({['prop']: prop} = new Foo());Expected behavior:
No error on destructuring with computed property name.
Actual behavior:
Error on all statically known property names.
Playground Link:
Related Issues:
Andy (Andrewkraft) (@Andy-MS) this was introduced in #26381 while fixing #26355
Activity
RyanCavanaugh commentedon Aug 21, 2018
I'm really tempted to Won't Fix this because the whole "private properties can be accessed via indexing" thing feels like something we only do because we did it in 0.8, and destructuring is new enough that it doesn't feel like this would break anything major.
Klaus Meinhardt (@ajafff) is this affecting you, or just something you noticed?
ajafff commentedon Aug 21, 2018
I just noticed that it's inconsistent with other element access with computed names.
If you say this is working as intended, that's fine for me. In that case you might want to consider reverting the recent change to destructuring BindingElement.
RyanCavanaugh commentedon Aug 21, 2018
Which part of it specifically?
ajafff commentedon Aug 21, 2018
#26360
RyanCavanaugh commentedon Aug 23, 2018
Not going to keep around consistency of the sake of inconsistency.