Repository navigation
Missing URL constructor definition #2583
Description
Currently:
interface URL {
revokeObjectURL(url: string): void;
createObjectURL(object: any, options?: ObjectURLOptions): string;
}
declare var URL: URL;Should be:
interface URLConstructor {
hash: string;
search: string;
pathname: string;
port: string;
hostname: string;
host: string;
password: string;
username: string;
protocol: string;
origin: string;
href: string;
}
interface URL {
revokeObjectURL(url: string): void;
createObjectURL(object: any, options?: ObjectURLOptions): string;
new(url: string, base?: string): URLConstructor
}
declare var URL: URL;URL spec is here: https://url.spec.whatwg.org/#api
Activity
kennysong commentedon Jun 8, 2015
Where is the URL interface currently defined? I can't find it.
mhegazy commentedon Jun 8, 2015
it is defined in lib.d.ts.
kennysong commentedon Jun 8, 2015
It doesn't seem to be in lib.d.ts.
danquirk commentedon Jun 8, 2015
GitHub isn't showing the whole file. It cuts off around 11k lines but URL is defined on line 14455
mhegazy commentedon Jun 8, 2015
look at the raw view: https://raw.githubusercontent.com/Microsoft/TypeScript/master/bin/lib.d.ts
29 remaining items
RReverser commentedon Jan 13, 2016
I don't really see how is that a problem - just because public release of Edge doesn't support some new spec APIs natively, that doesn't mean people don't use those APIs (through polyfills, in other browsers, etc.) and doesn't mean they don't want those definitions as soon as they're available... Or am I missing something?
mhegazy commentedon Jan 14, 2016
Ingvar Stepanyan (@RReverser), I am not sure i understand the problem or the proposal here.
We have lib.d.ts that is generated from the IE/Edge IDL files. Zhengbo Li (@zhengbli) updates they, usually quertelly/semi anally.
These definition files may not contain all APIs, or include addtional non-standard ones, or ones that are not standard-complient, for that, we have three files: https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/overridingTypes.json, https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/addedTypes.json and https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/removedTypes.json that we use to make the output correct.
The PR to add URL constructor for instance is using these fiels, see: microsoft/TypeScript-DOM-lib-generator#44.
so am i missing something?
RReverser commentedon Jan 14, 2016
Gotcha - this was the part I wasn't aware about and thus asked
(I thought it's just that internal builds contain APIs that are not released yet, but are fully spec-compliant and still could be used for TS; thanks for explanations)
NekR commentedon Mar 27, 2016
I am on TS
1.8.9and this is almost April now, haven't you generated new version yet?mhegazy commentedon Mar 28, 2016
Arthur Stolyar (@NekR), PRs are welcomed. see more information in #2583 (comment)
zhengbli commentedon Mar 28, 2016
As an update, this issue should be fixed by #7619
We recently took a new drop of the XML spec which has the correct definitions for URL.
NekR commentedon Mar 28, 2016
Great, thanks for the update.
pritambaral commentedon May 30, 2016
Zhengbo Li (@zhengbli) When may we see the fix? The latest release 1.8.10 doesn't have it.
zhengbli commentedon May 31, 2016
It is already in master: https://github.com/Microsoft/TypeScript/blob/35b8b42b554d2b98230320b727b452d0abe9aaae/src/lib/dom.generated.d.ts#L11740
it should be in next release.