Repository navigation
quick fix for function only contains one jsx element and have not the return statement #25751
Description
Activity
Great idea. It doesn't even have to be limited to JSX. I'm not sure how we'd plumb the logic through, but there are two fixes I'd have in mind:
- For any block body containing a single ExpressionStatement whose expression's type matches the expected type, suggest the following:
- Add a
returnstatement. - Remove block body braces.
- Replace braces with parentheses.
- For any block body containing only a labeled ExpressionStatement, check to see if the expected type contains a property with the same name as the label, and if so, suggest
- Wrap this block with parentheses.
Reacted by Wenlu Wangshould that a quickfix? maybe refactor is more suitable
Well, I guess your example is a refactoring since there's no error (you just end up producing a
void[].The cases I have in mind should have an associated error.
Reacted by Wenlu Wangsometime we cannot infer the return type(no context, no type annotation)
will we ignore those case?need some help:
how could i know type are related in quick fix withoutisTypeRelatedTo😢Thanks Wenlu Wang (@Kingwl)!
Search Terms
quickfix, jsx, function
Suggestion
quick fix for function only contains one jsx element and have not the return statement
Use Cases
the pattern of a function with block body that only have one jsx element without return statement
that seems a error
could we provide a quickfix for that?
Examples
to
Checklist
My suggestion meets these guidelines: