Skip to content

"rename file" and "move to new file" refactors do not work when using files #24857

Closed
#25623
Closed
"rename file" and "move to new file" refactors do not work when using files#24857
#25623
Assignees
sheetalkamat
Labels
BugA bug in TypeScriptFixedA PR has been merged for this issueNeeds More InfoThe issue still hasn't been fully clarified
Milestone
TypeScript 3.3

Description

@OliverJAsh
Oliver Joseph Ash (OliverJAsh)
opened on Jun 11, 2018

TypeScript Version: 2.9.1

Search Terms:
files "move to new file" "rename file"

Code

// tsconfig.json
{
  "files": ["./src/index.ts"]
}
// ./src/index.ts
import foo from './other';
// ./src/other.ts
export default {}

const bar = {};

Expected behavior:

  • When renaming the file ./src/other.ts, I expect TypeScript/VSCode to prompt me to update the import in ./src/index.ts.
  • When selecting bar in ./src/other.ts, TypeScript/VSCode offers to move this to a new file. When actioning this, I expect this to work.

(TypeScript knows that ./src/other.ts is in the project because it is part of the traced dependency graph from the entry file ./src/index.ts.)

Actual behavior:

  • When renaming the file ./src/other.ts, there is no prompt to update the import.
  • When selecting bar in ./src/other.ts, TypeScript/VSCode offers to move this to a new file. When actioning this, nothing happens.

Playground Link:

Related Issues:
microsoft/vscode#51366
#23573
#23726

A known workaround is to use the include option instead of files. However, I am curious why this is necessary. I prefer to list the entry file and let TypeScript work the rest out. This is especially helpful when a folder has a combination of source and test files—TypeScript automatically knows not to include the test files because they are not part of the dependency graph.

If there is a good reason why these commands/refactors can't work with files, could we make the experience clearer? Why is the "move to new file" command suggested in VSCode when it leads to nothing? If so, perhaps this is an issue for VSCode.

Activity

  1. mhegazy commented on Jun 11, 2018

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Jun 11, 2018
    Contributor

    Can you share the log from your tsserver? i suspect it is a duplicate of #24613

  2. Mohamed Hegazy (mhegazy)
    added
    Needs More InfoThe issue still hasn't been fully clarified
    on Jun 11, 2018

  3. OliverJAsh commented on Jun 12, 2018

    @OliverJAsh
    Oliver Joseph Ash (OliverJAsh)
    on Jun 12, 2018
    ContributorAuthor

    Mohamed Hegazy (@mhegazy) Does this help? tsserver.log

  4. Mohamed Hegazy (mhegazy)
    added
    BugA bug in TypeScript
    and removed
    Needs More InfoThe issue still hasn't been fully clarified
    on Jun 12, 2018
  5. Mohamed Hegazy (mhegazy)
    assigned
    Sheetal Nandi (sheetalkamat)
    on Jun 12, 2018
  6. Mohamed Hegazy (mhegazy)
    added this to the TypeScript 3.0 milestone on Jun 12, 2018

  7. mhegazy commented on Jun 12, 2018

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Jun 12, 2018
    Contributor

    This looks different.

  8. sheetalkamat commented on Jun 13, 2018

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Jun 13, 2018
    Member

    Matt Bierner (@mjbvz) this seems like there are 2 open requests on same file. Can you check why? We do not expect open on same file without closing it first. Thats the assert that raised error in the log.
    Interesting open requests:

    Info 7    [11:4:3.833] request:
    {"seq":0,"type":"request","command":"open","arguments":{"file":"/Users/OliverJAsh/Development/temp/typescript-files-refactors-test/src/index.ts","fileContent":"// ./src/index.ts\nimport foo from './other';"}}

nfo 52   [11:4:7.163] request:
    {"seq":6,"type":"request","command":"open","arguments":{"file":"/Users/OliverJAsh/Development/temp/typescript-files-refactors-test/src/index.ts","fileContent":"// ./src/index.ts\nimport foo from './other';","scriptKindName":"TS","projectRootPath":"/Users/OliverJAsh/Development/temp/typescript-files-refactors-test"}}

  9. mjbvz commented on Jun 27, 2018

    @mjbvz
    Matt Bierner (mjbvz)
    on Jun 27, 2018
    Contributor

    Oliver Joseph Ash (@OliverJAsh) Can you please try collecting the TS Server log again in the latest VS Code insiders build. I made some changes to how we track opened files and haven't been able to reproduce the duplicate open requests in recent VS Code builds

  10. OliverJAsh commented on Jun 28, 2018

    @OliverJAsh
    Oliver Joseph Ash (OliverJAsh)
    on Jun 28, 2018
    ContributorAuthor

    Matt Bierner (@mjbvz) In this log I attempt to use the "move to new file" command as described in my original post.
    tsserver.log

    Matt Bierner (@mjbvz) Are you able to reproduce the issue as I described?

  11. mhegazy commented on Jun 30, 2018

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Jun 30, 2018
    Contributor

    Oliver Joseph Ash (@OliverJAsh) looks like this log is using typescript@2.9.1 can you try with typescript@next?

  12. sheetalkamat commented on Jul 2, 2018

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Jul 2, 2018
    Member

    Oliver Joseph Ash (@OliverJAsh) The error you are seeing in the log, i think is fixed by #24613. Please try typescript@next and let us know if you still see the issue. Thank you.

  13. Mohamed Hegazy (mhegazy)
    added
    FixedA PR has been merged for this issue
    on Jul 2, 2018
  14. Mohamed Hegazy (mhegazy)
    closed this as completedon Jul 2, 2018

  15. 43 remaining items

  16. Daniel Rosenwasser (DanielRosenwasser)
    modified the milestones: TypeScript 3.2, TypeScript 3.2.1 on Nov 13, 2018
  17. Repository owner unassigned on Nov 16, 2018
  18. ghost assigned
    Sheetal Nandi (sheetalkamat)
    on Nov 16, 2018
  19. Daniel Rosenwasser (DanielRosenwasser)
    modified the milestones: TypeScript 3.2.1, TypeScript 3.3.0 on Nov 29, 2018

  20. sheetalkamat commented on Jan 3, 2019

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Jan 3, 2019
    Member

    Oliver Joseph Ash (@OliverJAsh) Sorry for getting back but can you please try your repro with typescript@next and see if it repros. Providing log if it repros will help. Thanks.

  21. Sheetal Nandi (sheetalkamat)
    added
    Needs More InfoThe issue still hasn't been fully clarified
    on Jan 3, 2019

  22. OliverJAsh commented on Jan 5, 2019

    @OliverJAsh
    Oliver Joseph Ash (OliverJAsh)
    on Jan 5, 2019
    ContributorAuthor

    Testing "move to new file", unfortunately that doesn't seem to help.

    tsserver.log

  23. sheetalkamat commented on Jan 7, 2019

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Jan 7, 2019
    Member

    Oliver Joseph Ash (@OliverJAsh) Thank you for the log. Will investigate.

  24. sheetalkamat commented on Jan 11, 2019

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Jan 11, 2019
    Member

    Oliver Joseph Ash (@OliverJAsh) its been now fixed by #26280 Please verify with typescript@next and report back with tsserver log if it still repros. Thank you,

  25. Sheetal Nandi (sheetalkamat)
    closed this as completedon Jan 11, 2019

  26. OliverJAsh commented on Jan 13, 2019

    @OliverJAsh
    Oliver Joseph Ash (OliverJAsh)
    on Jan 13, 2019
    ContributorAuthor

    It fixes the problem—thank you! One small thing though: it adds the new file to files even though it doesn't need to be (when it's included via the dependency graph of existing files).

  27. sheetalkamat commented on Jan 14, 2019

    @sheetalkamat
    Sheetal Nandi (sheetalkamat)
    on Jan 14, 2019
    Member

    Oliver Joseph Ash (@OliverJAsh) can you please share tsserver log where your newFile gets added to the files list? I don't see that when I do it with typescript@next

  28. microsoft
    locked as resolved and limited conversation to collaborators on Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptFixedA PR has been merged for this issueNeeds More InfoThe issue still hasn't been fully clarified

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions