Duplicate identifier error in services for commonjs module.exports.prop =  #24024

Activity

1. ghost added

   BugA bug in TypeScriptA bug in TypeScript

   on May 10, 2018
2. ghost added

   Salsa

   on May 10, 2018
3. Mohamed Hegazy (mhegazy)

   assigned

   Nathan Shively-Sanders (sandersn)

   on May 10, 2018
4. Mohamed Hegazy (mhegazy)

   added this to the TypeScript 2.9.1 milestone on May 10, 2018
5. Mohamed Hegazy (mhegazy)

   modified the milestones: TypeScript 2.9.1, TypeScript 2.9.2 on May 22, 2018
6. Mohamed Hegazy (mhegazy)

   modified the milestones: TypeScript 2.9.2, TypeScript 3.0 on May 29, 2018
7. sandersn commented on May 29, 2018

   

   Nathan Shively-Sanders (sandersn)

   on May 29, 2018

   Member

   More actions

   Note that adding a third line in a.js, var d = new D(), causes a crash in resolveName, even from the command line. I'll file that as a separate bug.
8. sandersn commented on May 30, 2018

   

   Nathan Shively-Sanders (sandersn)

   on May 30, 2018

   Member

   More actions

   Andy (Andrewkraft) (@Andy-MS) helped me find a repro that works from the command line. Put the require in the same file:

   var wat = require('./test')
   module.exports = class C {}
   module.exports.D = class D { }

   Note that the require has to be first. My current hypothesis is that getCommonJsExportEquals creates a merged symbol which is !== the symbol for class D, thereby evading the check I added in #24466. I have a simpler fix that I will put up shortly.
9. Nathan Shively-Sanders (sandersn)

   added

   FixedA PR has been merged for this issueA PR has been merged for this issue

   on May 30, 2018
10. Nathan Shively-Sanders (sandersn)

    closed this as completedin #24491on May 30, 2018
11. microsoft

    locked and limited conversation to collaborators on Jul 31, 2018