Repository navigation
Organize Imports: Debug Failure. Did not expect InterfaceDeclaration to have an Identifier in its trivia #22924
Description
TypeScript Version: 2.9.0-dev.20180327
Search Terms:
- Organize imports
Code
- In the vscode codebase
- Open
modes.ts: https://github.com/Microsoft/vscode/blob/master/src/vs/editor/common/modes.ts - Delete the
{ IMarkerData }import - Run Organize imports
Bug:
Debug failure:
[Error - 13:54:12] 'organizeImports' request failed with error.
Error processing request. Debug Failure. Did not expect InterfaceDeclaration to have an Identifier in its trivia
Error: Debug Failure. Did not expect InterfaceDeclaration to have an Identifier in its trivia
at NodeObject.addSyntheticNodes (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:83936:34)
at processNode (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:83980:29)
at NodeObject.createChildren (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:83994:21)
at NodeObject.getChildren (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:84020:22)
at getTokenAtPositionWorker (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:66397:43)
at getTouchingToken (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:66384:16)
at Object.getTouchingPropertyName (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:66380:16)
at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:71736:47
at Array.some (native)
at Object.isSymbolReferencedInFile (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:71735:85)
at isDeclarationUsed (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:74069:102)
at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:74055:95
at Array.filter (native)
at removeUnusedImports (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:74055:66)
at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:74006:43
at Object.flatMap (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:1774:25)
at organizeImportsWorker (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:74004:41)
at Object.organizeImports (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:73989:13)
at Object.organizeImports (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:85310:39)
at IOSession.Session.organizeImports (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:92327:60)
at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:91225:61)
at /Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:92510:88
at IOSession.Session.executeWithRequestId (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:92501:28)
at IOSession.Session.executeCommand (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:92510:33)
at IOSession.Session.onMessage (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:92530:35)
at Interface.<anonymous> (/Users/matb/projects/vscode/node_modules/typescript/lib/tsserver.js:93738:27)
at emitOne (events.js:96:13)
at Interface.emit (events.js:191:7)
at Interface._onLine (readline.js:241:10)
at Interface._normalWrite (readline.js:384:12)
at Socket.ondata (readline.js:101:10)
at emitOne (events.js:96:13)
at Socket.emit (events.js:191:7)
at readableAddChunk (_stream_readable.js:178:18)
at Socket.Readable.push (_stream_readable.js:136:10)
at Pipe.onread (net.js:560:20)
Also occurs on references
Activity
sheetalkamat commentedon Mar 28, 2018
Looking into the log to see whats going on.
sheetalkamat commentedon Mar 28, 2018
The issue is that JSDoc node doesnt have updated the positions after the incremental parsing:
Before edit: And after edit the pos and end of this.JsDoc have not changed.
Before edit
this.jsDoc[0].getFullText()
"/** internal */"
After edit
this.jsDoc[0].getFullText()
" }"
Correct the incremental parsing when there is jsDoc node
Correct the incremental parsing when there is jsDoc node