Skip to content

Review replaceNode #21246

New issue
New issue
Closed
Closed
Review replaceNode#21246
Labels
InfrastructureIssue relates to TypeScript team infrastructure

Description

@ghost
ghost
opened on Jan 17, 2018

This function should be checked that it properly handles leading and trailing trivia of the node.
We should probably use replaceNode instead of replaceRange in fixUnusedIdentifier.ts. See #21144 (comment)

Activity

  1. Mohamed Hegazy (mhegazy)
    added
    InfrastructureIssue relates to TypeScript team infrastructure
    on Jan 17, 2018

  2. amcasey commented on Jan 17, 2018

    @amcasey
    Andrew Casey (amcasey)
    on Jan 17, 2018
    Member

    extractSymbol.ts also make heavy use of replaceRange.

  3. RyanCavanaugh commented on Dec 15, 2021

    @RyanCavanaugh
    Ryan Cavanaugh (RyanCavanaugh)
    on Dec 15, 2021
    Member

    Looks like we got them all

  4. Ryan Cavanaugh (RyanCavanaugh)
    closed this as completedon Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    InfrastructureIssue relates to TypeScript team infrastructure

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions