Repository navigation
Partial<T> where T has only optional members should not yield ... has no properties in common with type 'Partial<...>'error #20999
Description
tsc v2.6.2
Here's an example from jcormont/documentdb-typescript, Collection.d.ts in attempting to support this new ttl field:
storeDocumentAsync<T extends Partial<_DocumentDB.DocumentResource>>(data: T, mode?: StoreMode, maxRetries?: number, options?: AllOptions): Promise<T & _DocumentDB.DocumentResource>;
...
export interface DocumentResource extends Resource {
ttl?: number;
}If I opt NOT to include a ttl, I get [ts] Type 'MyDocument' has no properties in common with type 'Partial<DocumentResource>'.
const stored = await myDocuments.storeDocumentAsync(myDocument, StoreMode.CreateOnly);I can work around it like this, but it is ugly:
const stored = await myDocuments.storeDocumentAsync({ ... myDocument, ttl: undefined }, StoreMode.CreateOnly);
Activity
DanielRosenwasser commentedon Jan 4, 2018
I believe this is working as intended as part of weak type checking (#16047).
As a side question, does
myDocumentnot have anidfield? I would thinkMyDocumentwould extend fromResourceat the least.typescript-bot commentedon Jan 20, 2018
Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.
jcormont commentedon Feb 17, 2018
Just for reference, this has been fixed by adding
& objectto the type specification for the first parameter ofstoreDocumentAsync.This makes sense: documents are always 'real' objects (not Numbers, Strings etc) and it seems to stop the TypeScript compiler from being overzealous and warning about common properties -- probably because there are common properties such as
hasOwnProperty.