Add formik to the user test suite

It seems that #20891 affects users of Formik, a React forms library.

It'd be good to have
some extra coverage https://github.com/jaredpalmer/formik

Daniel Rosenwasser (@DanielRosenwasser)

Daniel Rosenwasser (@DanielRosenwasser) Do you have an actual TS example project for that library? I don't think the reported issue surfaces when just checking the .d.ts file.

I think both of the two examples will error

// (1) - explicit parameter annotation
interface FormTypes { firstName: string }
let el1 = <Formik
    initialValues={{ firstName: "Daniel"}}
    onSubmit={(values: FormTypes) => console.log("First name", values.firstName)} />


// (2) - parameter should be inferred, ends up as {}
let el2 = <Formik
    initialValues={{ firstName: "Daniel"}}
    onSubmit={values => console.log("First name", values.firstName)} />

If the only value of adding formik is as an end-to-end equivalent to the test for a fix to #20891, then I don't think it's worth it. Are there other properties of formik as a dependency that make it useful?

Nathan Shively-Sanders (@sandersn)

Nathan Shively-Sanders (@sandersn) IMHO this is more of a DX thing. On the one hand, adding tests for Apollo, Formik, etc might seem redundant. On the other hand, seems like a good idea to guarantee that the most popular libraries on GitHub are always compatible with the latest version of TypeScript (and are using the latest and greatest TS features).

Good point. I do think that we’ll need more code than our typical import x from "library" for this test.

Nathan Shively-Sanders (@sandersn)

Nathan Shively-Sanders (@sandersn) are the two issues (jaredpalmer/formik#283 and jaredpalmer/formik#314) fixed in master now? or we are still breaking formik?

Wesley Wigham (@weswigham)

Wesley Wigham (@weswigham) can we ensure formik runs clean on master after #20995 is merged.

This is in our user suite in master now. Provided nothing has changed since the PR, it's in a state where the .d.ts itself typechecks, but the example component does not.

formik typechecks nowadays, so I'm going to close this. 👍

Navigation Menu

Repository navigation

Add formik to the user test suite #20926

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Add formik to the user test suite #20926

Description

Activity

weswigham commented on Dec 29, 2017

DanielRosenwasser commented on Dec 29, 2017

sandersn commented on Jan 2, 2018

jaredpalmer commented on Jan 3, 2018

sandersn commented on Jan 3, 2018

mhegazy commented on Jan 19, 2018

mhegazy commented on Jan 19, 2018

weswigham commented on Feb 2, 2018

weswigham commented on Mar 3, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions