Repository navigation
The behavior of the intersection type of array changed in 2.6.1 #20001
Description
TypeScript Version: 2.6.1
Code
interface A {
first: string;
bList?: B[];
}
interface B {
second: string;
c?: C;
}
interface C {
third: string;
}
const Q: A & { bList: (B & { c: C })[] } = {
first: 'first',
bList: [
{
second: 'second',
c: {
third: 'third',
},
},
],
};
Q.bList.map(item => {
P(item);
});
function P(value: B & { c: C }) {
console.log(value);
}Expected behavior:
Until 2.5.1 this code did not generate a compilation error.
The type of bList is calculated as follows:
(undefined & (B & {
c: C;
})[]) | (B[] & (B & {
c: C;
})[])And type of item
B & {
c: C;
}Actual behavior:
With 2.6.x, this code causes an error.
The type of bList is calculated as follows:
B[] & (B & {
c: C[];
})[]And type of item
BThe type of item is treated as B and an error occurs. Is this change specified in the changelog?
Activity
ahejlsberg commentedon Nov 15, 2017
This is an effect of #18438. We now remove empty intersection types (i.e. intersection types for which no values exist) from union types. In your example, this means that
undefined & (B & { c: C })[]is removed when constructing the type forbList, leaving justB[] & (B & { c: C })[]. Then, as we look for amapmember on that type, we end up picking the candidate fromB[]and thereforeitemhas typeB. Previously we'd pick a candidate from(B & { c: C })[]because we didn't remove the empty intersection.In general, when the constituent types of intersections have overlapping signatures, the intersection is order sensitive because overload resolution processes the signatures from left to right. Indeed, your example works if you change the type of
Qto listAlast:icepeng commentedon Nov 16, 2017
It would be nice to write that the intersection type is order sensitive in the advanced types section of the typescript handbook.
typescript-bot commentedon Dec 1, 2017
Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.